#443: Allow setting of gitlab base url

Author: codedge

.github/workflows/markdown-normalize.yml

@@ -5,7 +5,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php: ['8.1']
+        php: ['8.1', '8.2']
         laravel: [10.*]
         dependency-version: [prefer-stable]
         include:

.github/workflows/tests.yml

@@ -38,7 +38,7 @@
         "dg/bypass-finals": "^1.4",
         "mikey179/vfsstream": "^1.6",
         "mockery/mockery": "^1.5",
-        "orchestra/testbench": "^8.0",
+        "orchestra/testbench": "^8.1",
         "phpunit/phpunit": "^9.5.26"
     },
     "minimum-stability": "dev",

composer.json

@@ -50,6 +50,7 @@
             'use_branch'           => env('SELF_UPDATER_USE_BRANCH', ''),
         ],
         'gitlab' => [
+            'base_url'            => '',
             'type'                 => 'gitlab',
             'repository_id'        => env('SELF_UPDATER_REPO_URL', ''),
             'download_path'        => env('SELF_UPDATER_DOWNLOAD_PATH', '/tmp'),

config/self-update.php

@@ -144,10 +144,19 @@ public function selectRelease(Collection $collection, string $version)
         return $release;
     }
 
-    final public function getReleases(): Response
+    /**
+     * @return array{base_url:string, url:string}
+     */
+    final public function getReleaseUrl(): array
     {
-        $url = '/api/v4/projects/'.$this->config['repository_id'].'/releases';
+        return [
+            'base_url' => $this->config['base_url'] ?? self::BASE_URL,
+            'url' => '/api/v4/projects/'.$this->config['repository_id'].'/releases',
+        ];
+    }
 
+    final public function getReleases(): Response
+    {
         $headers = [];
 
         if ($this->release->hasAccessToken()) {
@@ -156,6 +165,8 @@ final public function getReleases(): Response
             ];
         }
 
-        return Http::withHeaders($headers)->baseUrl(self::BASE_URL)->get($url);
+        $urls = $this->getReleaseUrl();
+
+        return Http::withHeaders($headers)->baseUrl($urls['base_url'])->get($urls['url']);
     }
 }

src/SourceRepositoryTypes/GitlabRepositoryType.php

@@ -174,4 +174,26 @@ public function it_takes_latest_release_if_no_other_found(): void
 
         $this->assertEquals('1.3', $gitlab->selectRelease(collect($items), '1.7')['tag_name']);
     }
+
+    /** @test */
+    public function it_can_use_default_base_url(): void
+    {
+        /** @var GitlabRepositoryType $gitlab */
+        $gitlab = resolve(GitlabRepositoryType::class);
+        $urls = $gitlab->getReleaseUrl();
+
+        $this->assertEquals('https://gitlab.com', $urls['base_url']);
+    }
+
+    /** @test */
+    public function it_can_use_base_url_from_config(): void
+    {
+        config(['self-update.repository_types.gitlab.base_url' => 'https://example.local']);
+
+        /** @var GitlabRepositoryType $gitlab */
+        $gitlab = resolve(GitlabRepositoryType::class);
+        $urls = $gitlab->getReleaseUrl();
+
+        $this->assertEquals('https://example.local', $urls['base_url']);
+    }
 }