Skip to content

Manifest#Attribute#writeLine does not properly calculate max line length #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michael-o opened this issue Jan 1, 2016 · 0 comments
Closed

Manifest#Attribute#writeLine does not properly calculate max line length #18

michael-o opened this issue Jan 1, 2016 · 0 comments
Assignees
@michael-o
Labels
bug
Milestone
3.3

Comments

@michael-o
Copy link
Member

This method does line.getBytes().length > MAX_LINE_LENGTH and section.getBytes().length > MAX_SECTION_LENGTH. Ignoring that getBytes() relies on platform encoding. If the encoding is not UTF-8, the length in bytes might be calculated incorrectly and the output doesn't conform to the manifest spec anymore.
@michael-o michael-o added the bug label May 20, 2016
@michael-o michael-o added this to the 3.3 milestone May 21, 2016
@michael-o michael-o self-assigned this May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-o michael-o

Labels
bug
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
1 participant
@michael-o