Skip to content

Commit cee4f63

Browse files
committed
Require Java 8
1 parent 3473197 commit cee4f63

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Plexus Language
22
![Build Status](https://github.com/codehaus-plexus/plexus-languages/workflows/GitHub%20CI/badge.svg)
3+
![GitHub Workflow Status](https://img.shields.io/github/workflow/status/codehaus-plexus/plexus-languages/GitHub%20CI)
34

45
Plexus Languages:
56

plexus-java/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
<name>Plexus Languages :: Java</name>
1313

1414
<properties>
15-
<maven.compiler.source>1.7</maven.compiler.source>
16-
<maven.compiler.target>1.7</maven.compiler.target>
15+
<maven.compiler.source>1.8</maven.compiler.source>
16+
<maven.compiler.target>1.8</maven.compiler.target>
1717
</properties>
1818

1919
<build>

plexus-java/src/site/markdown/locationmanager.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
The plexus-java library is created to have a solution for common activities, so this business logic doesn't have to be maintained at multiple places. The first provided feature was the `LocationManager` to analyze module desciptors and to decide which jars should end up on the modulepath and which on the classpath. The name was based on the [javax.tools.JavaFileManager.Location]. (https://docs.oracle.com/javase/10/docs/api/javax/tools/JavaFileManager.Location.html)
22

3-
The library requires Java 7 to run, but contains optimized code for Java 9. By requiring Java 7 it was much easier to embed this library in several other projects.
3+
The library requires Java 8 to run, but contains optimized code for Java 9. By requiring Java 8 it was much easier to embed this library in several other projects.
44

5-
This jar is a multi release jar (aka MRJAR), because it contains 2 implementations for the `BinaryModuleInfoParser`. If the Java runtime is 9 or above, the `java.lang.module.ModuleDescriptor` is used to read the `module-info.class`. If the runtime is Java 7 or Java 8, then ASM is used to read the module descriptor.
5+
This jar is a multi release jar (aka MRJAR), because it contains 2 implementations for the `BinaryModuleInfoParser`. If the Java runtime is 9 or above, the `java.lang.module.ModuleDescriptor` is used to read the `module-info.class`. If the runtime is Java 8, then ASM is used to read the module descriptor.
66

77
When extracting the the automatic module name based the of the file, it is a little bit more complex. The result must be precise, so the only way to solve this is by calling Java 9 code, either from the runtime or by calling Java 9 explicitly when provided via `ResolvePathsRequest.setJdkHome`.
88

@@ -26,7 +26,7 @@ Additional methods are:
2626

2727
- `setIncludeAllProviders`, in general would only be used at runtime, not during compile or test. In case `uses` is used, all modules with matching `provides` are added as well.
2828

29-
- `setJdkHome`, should point to Java 9 or above in case the runtime of this library is Java 7 or 8
29+
- `setJdkHome`, should point to Java 9 or above in case the runtime of this library is Java 8
3030

3131
- `setMainModuleDescriptor`, which can either be a `module-info.java` or `module-info.class`
3232

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<properties>
4242
<scm.url>scm:git:[email protected]:codehaus-plexus/plexus-languages.git</scm.url>
4343
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
44-
<javaVersion>7</javaVersion>
44+
<javaVersion>8</javaVersion>
4545
<project.build.outputTimestamp>2021-03-27T12:17:24Z</project.build.outputTimestamp>
4646
</properties>
4747

0 commit comments

Comments
 (0)