Skip to content

Commit 49c4772

Browse files
authored
Merge pull request #7661 from kenjis/refactor-Commands-Utilities-Routes
refactor: remove uneeded `if` in Commands\Utilities\Routes
2 parents 0bfe339 + 6878e43 commit 49c4772

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

system/Commands/Utilities/Routes.php

+13-16
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace CodeIgniter\Commands\Utilities;
1313

14-
use Closure;
1514
use CodeIgniter\CLI\BaseCommand;
1615
use CodeIgniter\CLI\CLI;
1716
use CodeIgniter\Commands\Utilities\Routes\AutoRouteCollector;
@@ -119,21 +118,19 @@ public function run(array $params)
119118
$definedRouteCollector = new DefinedRouteCollector($collection);
120119

121120
foreach ($definedRouteCollector->collect() as $route) {
122-
if (is_string($route['handler']) || $route['handler'] instanceof Closure) {
123-
$sampleUri = $uriGenerator->get($route['route']);
124-
$filters = $filterCollector->get($route['method'], $sampleUri);
125-
126-
$routeName = ($route['route'] === $route['name']) ? '»' : $route['name'];
127-
128-
$tbody[] = [
129-
strtoupper($route['method']),
130-
$route['route'],
131-
$routeName,
132-
$route['handler'],
133-
implode(' ', array_map('class_basename', $filters['before'])),
134-
implode(' ', array_map('class_basename', $filters['after'])),
135-
];
136-
}
121+
$sampleUri = $uriGenerator->get($route['route']);
122+
$filters = $filterCollector->get($route['method'], $sampleUri);
123+
124+
$routeName = ($route['route'] === $route['name']) ? '»' : $route['name'];
125+
126+
$tbody[] = [
127+
strtoupper($route['method']),
128+
$route['route'],
129+
$routeName,
130+
$route['handler'],
131+
implode(' ', array_map('class_basename', $filters['before'])),
132+
implode(' ', array_map('class_basename', $filters['after'])),
133+
];
137134
}
138135

139136
if ($collection->shouldAutoRoute()) {

0 commit comments

Comments
 (0)