Skip to content

Commit 248c2ad

Browse files
committed
helm: Fix README examples
Not sure where --name came from? Maybe an older version of helm. Ah, it's from v2.16.7
1 parent 52ea32f commit 248c2ad

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

ci/helm-chart/README.md

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ This chart is community maintained by [@Matthew-Beckett](https://github.com/Matt
1010
## TL;DR;
1111

1212
```console
13-
$ git clone https://github.com/cdr/code-server.git
14-
$ helm install code-server charts/code-server
13+
$ git clone https://github.com/cdr/code-server
14+
$ cd code-server
15+
$ helm upgrade --install code-server ci/helm-chart
1516
```
1617

1718
## Introduction
@@ -26,10 +27,12 @@ package manager.
2627

2728
## Installing the Chart
2829

29-
To install the chart with the release name `my-release`:
30+
To install the chart with the release name `code-server`:
3031

3132
```console
32-
$ helm install --name my-release charts/code-server
33+
$ git clone https://github.com/cdr/code-server
34+
$ cd code-server
35+
$ helm upgrade --install code-server ci/helm-chart
3336
```
3437

3538
The command deploys code-server on the Kubernetes cluster in the default
@@ -40,10 +43,10 @@ that can be configured during installation.
4043
4144
## Uninstalling the Chart
4245

43-
To uninstall/delete the `my-release` deployment:
46+
To uninstall/delete the `code-server` deployment:
4447

4548
```console
46-
$ helm delete my-release
49+
$ helm delete code-server
4750
```
4851

4952
The command removes all the Kubernetes components associated with the chart and
@@ -97,9 +100,9 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm
97100
install`. For example,
98101

99102
```console
100-
$ helm install --name my-release \
101-
--set persistence.enabled=false \
102-
deployment/chart
103+
$ helm install code-server \
104+
ci/helm-chart \
105+
--set persistence.enabled=false
103106
```
104107

105108
The above command sets the the persistence storage to false.
@@ -108,7 +111,7 @@ Alternatively, a YAML file that specifies the values for the above parameters
108111
can be provided while installing the chart. For example,
109112

110113
```console
111-
$ helm install --name my-release -f values.yaml deployment/chart
114+
$ helm install code-server ci/helm-chart -f values.yaml
112115
```
113116

114117
> **Tip**: You can use the default [values.yaml](values.yaml)

ci/helm-chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ persistence:
112112
##
113113
# storageClass: "-"
114114
accessMode: ReadWriteOnce
115-
size: 1Gi
115+
size: 10Gi
116116
annotations: {}
117117
# existingClaim: ""
118118
# hostPath: /data

0 commit comments

Comments
 (0)