Skip to content

[Chore]: fix brew workflow #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Mar 4, 2022 · 3 comments · Fixed by #4996 or #5025
Closed

[Chore]: fix brew workflow #4950

jsjoeio opened this issue Mar 4, 2022 · 3 comments · Fixed by #4996 or #5025
Assignees
Labels
chore Related to maintenance or clean up ci Issues related to ci
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 4, 2022

https://github.com/coder/code-server/runs/4974830516?check_suite_focus=true#step:5:142

@jsjoeio jsjoeio added ci Issues related to ci chore Related to maintenance or clean up labels Mar 4, 2022
@jsjoeio jsjoeio added this to the March 2022 milestone Mar 4, 2022
@jsjoeio jsjoeio self-assigned this Mar 8, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 23, 2022

fatal: unable to access 'https://github.com/cdrci/homebrew-core.git/': The requested URL returned error: 403

As you can see, this was not fixed in 4.2.0: https://github.com/coder/code-server/runs/5652853615?check_suite_focus=true#step:6:69

This is interesting because it worked on my fork under jsjoeio/code-server. I don't know if there's a permission needed under coder the GitHub org, or something related to cdrci.

I think the next steps are to try starting from scratch and using the --dry-run flag with the brew bump-formula-pr in code-server CI since we learned that running there vs. a fork's CI produces different results.

Thoughts

I'm guessing we need to overwrite GITHUB_TOKEN in CI when we run brew bump-formula-pr otherwise, it will use the author's GitHub creds, their homebrew-core fork and open the PR from them (which is not what we want).

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 23, 2022

Based on this testing, I think I can open a PR to simplify the brew bump-formula-pr process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up ci Issues related to ci
Projects
None yet
1 participant