Skip to content

Commit 4d25315

Browse files
authored
Revert "feat(vscode-web): allow pinning vscode-web binary to a specific commit ID" (#403)
1 parent 3d33656 commit 4d25315

File tree

3 files changed

+6
-20
lines changed

3 files changed

+6
-20
lines changed

vscode-web/README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Automatically install [Visual Studio Code Server](https://code.visualstudio.com/
1515
module "vscode-web" {
1616
count = data.coder_workspace.me.start_count
1717
source = "registry.coder.com/modules/vscode-web/coder"
18-
version = "1.0.30"
18+
version = "1.0.29"
1919
agent_id = coder_agent.example.id
2020
accept_license = true
2121
}
@@ -31,7 +31,7 @@ module "vscode-web" {
3131
module "vscode-web" {
3232
count = data.coder_workspace.me.start_count
3333
source = "registry.coder.com/modules/vscode-web/coder"
34-
version = "1.0.30"
34+
version = "1.0.29"
3535
agent_id = coder_agent.example.id
3636
install_prefix = "/home/coder/.vscode-web"
3737
folder = "/home/coder"
@@ -45,7 +45,7 @@ module "vscode-web" {
4545
module "vscode-web" {
4646
count = data.coder_workspace.me.start_count
4747
source = "registry.coder.com/modules/vscode-web/coder"
48-
version = "1.0.30"
48+
version = "1.0.29"
4949
agent_id = coder_agent.example.id
5050
extensions = ["github.copilot", "ms-python.python", "ms-toolsai.jupyter"]
5151
accept_license = true
@@ -60,7 +60,7 @@ Configure VS Code's [settings.json](https://code.visualstudio.com/docs/getstarte
6060
module "vscode-web" {
6161
count = data.coder_workspace.me.start_count
6262
source = "registry.coder.com/modules/vscode-web/coder"
63-
version = "1.0.30"
63+
version = "1.0.29"
6464
agent_id = coder_agent.example.id
6565
extensions = ["dracula-theme.theme-dracula"]
6666
settings = {

vscode-web/main.tf

-7
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,6 @@ variable "install_prefix" {
5959
default = "/tmp/vscode-web"
6060
}
6161

62-
variable "vscode_web_commit_id" {
63-
type = string
64-
description = "Specify the commit ID of the VS Code Web binary to pin to a specific version. If left empty, the latest stable version is used."
65-
default = ""
66-
}
67-
6862
variable "extensions" {
6963
type = list(string)
7064
description = "A list of extensions to install."
@@ -157,7 +151,6 @@ resource "coder_script" "vscode-web" {
157151
FOLDER : var.folder,
158152
AUTO_INSTALL_EXTENSIONS : var.auto_install_extensions,
159153
SERVER_BASE_PATH : local.server_base_path,
160-
VSCODE_WEB_COMMIT_ID : var.vscode_web_commit_id,
161154
})
162155
run_on_start = true
163156

vscode-web/run.sh

+2-9
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,8 @@ case "$ARCH" in
5959
;;
6060
esac
6161

62-
# Check if a specific VS Code Web commit ID was provided
63-
if [ -n "${VSCODE_WEB_COMMIT_ID}" ]; then
64-
HASH="${VSCODE_WEB_COMMIT_ID}"
65-
else
66-
HASH=$(curl -fsSL https://update.code.visualstudio.com/api/commits/stable/server-linux-$ARCH-web | cut -d '"' -f 2)
67-
fi
68-
printf "$${BOLD}VS Code Web commit id version $HASH.\n"
69-
70-
output=$(curl -fsSL "https://vscode.download.prss.microsoft.com/dbazure/download/stable/$HASH/vscode-server-linux-$ARCH-web.tar.gz" | tar -xz -C "${INSTALL_PREFIX}" --strip-components 1)
62+
HASH=$(curl -fsSL https://update.code.visualstudio.com/api/commits/stable/server-linux-$ARCH-web | cut -d '"' -f 2)
63+
output=$(curl -fsSL https://vscode.download.prss.microsoft.com/dbazure/download/stable/$HASH/vscode-server-linux-$ARCH-web.tar.gz | tar -xz -C ${INSTALL_PREFIX} --strip-components 1)
7164

7265
if [ $? -ne 0 ]; then
7366
echo "Failed to install Microsoft Visual Studio Code Server: $output"

0 commit comments

Comments
 (0)