Skip to content

Bug code-server plugin vscode settings #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gjrtimmer opened this issue Dec 2, 2024 · 2 comments
Closed

Bug code-server plugin vscode settings #357

gjrtimmer opened this issue Dec 2, 2024 · 2 comments
Labels
docs Improvements or additions to documentation help wanted Extra attention is needed

Comments

@gjrtimmer
Copy link

L.S.

I found the following bug. The settings variable of the code-server module is currently typed as [map(string).](https://github.com/coder/modules/blob/675c82367a3d53be5f719fca4444fbf5b0ce22ac/code-server/main.tf#L42) This is a bug, in my opinion, because it does now allow settings with subkeys to be used, which causes a Terraform error. After all, the value is not a string.

settings = {
  "yaml.customTags": [
    "!reference sequence",
    "!vault scalar",
    "inputs sequence"
  ]
}

FIX: To allow vscode setting to be set correctly, the type of the variable should be map(object).

Please advice.

@coder-labeler coder-labeler bot added docs Improvements or additions to documentation help wanted Extra attention is needed labels Dec 2, 2024
@matifali
Copy link
Member

matifali commented Dec 3, 2024

Duplicate of #296

@matifali matifali marked this as a duplicate of #296 Dec 3, 2024
@matifali
Copy link
Member

matifali commented Dec 3, 2024

Hi @gjrtimmer Thanks for highlighting this. Can you please leave your feedback on the existing issue. Also, we are open to contributions if you want to help fix this.
Thanks.

@matifali matifali closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants