write.go: Fix potential writeFrame deadlock

nhooyr · nhooyr · commit 5fe95bbfc293 · 2023-10-18T22:51:20.000-07:00
Closes #405 You should always be reading from the connection with CloseRead so this shouldn't have affected anyone using the library correctly.
diff --git a/write.go b/write.go
@@ -280,6 +280,7 @@ func (c *Conn) writeFrame(ctx context.Context, fin bool, flate bool, opcode opco
 				err = errClosed
 			case <-ctx.Done():
 				err = ctx.Err()
+			default:
 			}
 			c.close(err)
 			err = fmt.Errorf("failed to write frame: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -280,6 +280,7 @@ func (c *Conn) writeFrame(ctx context.Context, fin bool, flate bool, opcode opco`
`280`	`280`	`err = errClosed`
`281`	`281`	`case <-ctx.Done():`
`282`	`282`	`err = ctx.Err()`
	`283`	`+ default:`
`283`	`284`	`}`
`284`	`285`	`c.close(err)`
`285`	`286`	`err = fmt.Errorf("failed to write frame: %w", err)`