We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/nhooyr/websocket/blob/v1.8.11/accept.go#L237
Typically, path/filepath is used for OS-specific paths/etc while path has a OS neutral Match() method that works exactly the same in most cases.
path/filepath
path
Match()
A network lib shouldn't be using methods which behavior might vary depending on the OS.
The text was updated successfully, but these errors were encountered:
Good catch!
Sorry, something went wrong.
@nhooyr @MagicalTux I can submit a PR for this if that's OK with both of you
Go for it @KianYang-Lee!
is there a CONTRIBUTING.md for this @nhooyr so that proper steps can be taken before opening PR
CONTRIBUTING.md
4ce1d90
Successfully merging a pull request may close this issue.
https://github.com/nhooyr/websocket/blob/v1.8.11/accept.go#L237
Typically,
path/filepath
is used for OS-specific paths/etc whilepath
has a OS neutralMatch()
method that works exactly the same in most cases.A network lib shouldn't be using methods which behavior might vary depending on the OS.
The text was updated successfully, but these errors were encountered: