Skip to content

Commit 4b57a00

Browse files
authored
fix: allow finch commands to run using default config (runfinch#1109)
* fix: allow finch commands to run using default config Signed-off-by: Justin Alvarez <[email protected]> * update warning Signed-off-by: Justin Alvarez <[email protected]> --------- Signed-off-by: Justin Alvarez <[email protected]>
1 parent 839221c commit 4b57a00

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Diff for: cmd/finch/main_native.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
package main
77

88
import (
9+
"errors"
910
"fmt"
1011
"io"
12+
"os"
1113

1214
"github.com/spf13/afero"
1315
"github.com/spf13/cobra"
@@ -41,7 +43,11 @@ func xmain(logger flog.Logger,
4143
ecc,
4244
)
4345
if err != nil {
44-
return fmt.Errorf("failed to load config: %w", err)
46+
if errors.Is(err, os.ErrPermission) {
47+
logger.Warnf("Failed to load config, using default values. You may need to be root or use sudo. (%s)", err)
48+
} else {
49+
return fmt.Errorf("failed to load config: %w", err)
50+
}
4551
}
4652

4753
return newApp(

Diff for: pkg/config/config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ func Load(
137137
return nil, fmt.Errorf("failed to ensure %q directory: %w", cfgPath, err)
138138
}
139139
if err := writeConfig(defCfg, fs, cfgPath); err != nil {
140-
return nil, err
140+
log.Warnf("Could not save default values to %q: %w", cfgPath, err)
141141
}
142142
return defCfg, nil
143143
}

0 commit comments

Comments
 (0)