Skip to content

Commit 98c8ee4

Browse files
authored
fix: remove virtual machine image when running make clean
Original message "fix: Fix to remove the virtual machine storage in deps/finch-core/downloads/os by make clean" Issue #, if available: runfinch#537 *Description of changes:* In finch, when booting a virtual machine using Lima, it is necessary to download the virtual machine storage in QCOW2 format. The QCOW2 virtual machine storage thus downloaded and located in deps/finch-core/downloads/os is not deleted when make clean is run in the home directory as currently implemented. This file may be larger than 500 MB in size and is reported in issue/runfinch#537 such that it is expected to be deleted when make clean is run. Therefore, this fix will remove the QCOW2 format downloaded files in deps/finch-core/downloads/os when make clean is run in the home directory. *Testing done:* yes - [x] I've reviewed the guidance in CONTRIBUTING.md By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Hayato Kiwata <[email protected]> Co-authored-by: Hayato Kiwata <[email protected]>
1 parent 2537aa6 commit 98c8ee4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: Makefile

+1
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ clean:
327327
-sudo rm -rf "/private/etc/sudoers.d/finch-lima"
328328
-@rm -rf $(OUTDIR) 2>/dev/null || true
329329
-@rm -rf ./deps/finch-core/_output || true
330+
-@rm -rf ./deps/finch-core/downloads/os/$(FINCH_OS_BASENAME) || true
330331
-@rm ./*.tar.gz 2>/dev/null || true
331332
-@rm ./*.qcow2 2>/dev/null || true
332333
-@rm ./test-coverage.* 2>/dev/null || true

0 commit comments

Comments
 (0)