Skip to content

Commit e818743

Browse files
authored
fix: Change the default behavoir for deleting .finch folder to false when uninstall (runfinch#732)
Issue #, if available: *Description of changes:* To make homebrew keep the .finch folder when uninstall, change the uninstall script default option to not deleting the .finch folder *Testing done:* Tested locally by modifying the script after homebrew installation - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Kevin Li <[email protected]>
1 parent 8fd5a70 commit e818743

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: installer-builder/darwin/Resources/uninstall.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ fi
4949
#clean up ~/.finch directory
5050
while true; do
5151
read -r -p "Delete ~/.finch containing persistent user data [Y/n]? " answer
52-
if [[ $answer == "y" || $answer == "Y" || $answer == "" ]]
52+
if [[ $answer == "y" || $answer == "Y" ]]
5353
then
5454
[ -d ~/.finch ] && rm -rf ~/.finch
5555
if [ $? -eq 0 ]
@@ -59,7 +59,7 @@ while true; do
5959
echo "[4/4] [ERROR] Could not delete ~/.finch" >&2
6060
fi
6161
break
62-
elif [[ $answer == "n" || $answer == "N" ]]
62+
elif [[ $answer == "n" || $answer == "N" || $answer == "" ]]
6363
then
6464
echo "[4/4] Deletion of ~/.finch was aborted."
6565
break

0 commit comments

Comments
 (0)