Skip to content

Commit f441fc9

Browse files
authored
fix: Remove unnecessary error handling (runfinch#961)
Inside the ConfigureDefaultLimaYaml() function, there is a process to write to the config file as follows: ``` if err := afero.WriteFile(lca.fs, lca.limaDefaultConfigPath, limaCfgBytes, 0o600); err != nil { return fmt.Errorf("failed to write to the lima config file: %w", err) } if err != nil { return fmt.Errorf("unable to apply override config: %w", err) } ``` The current implementation has two error checks to determine if the file can be written. The err object in the second part is guaranteed to be nil due to the previous if statement. Therefore, this fix removes the unnecessary second error check. Issue #, if available: N/A *Description of changes:* The details are described in this commit message. *Testing done:* N/A - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Hayato Kiwata <[email protected]>
1 parent d3c4165 commit f441fc9

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

Diff for: pkg/config/lima_config_applier.go

-4
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,6 @@ func (lca *limaConfigApplier) ConfigureDefaultLimaYaml() error {
142142
return fmt.Errorf("failed to write to the lima config file: %w", err)
143143
}
144144

145-
if err != nil {
146-
return fmt.Errorf("unable to apply override config: %w", err)
147-
}
148-
149145
return nil
150146
}
151147

0 commit comments

Comments
 (0)