Skip to content

Commit f64835d

Browse files
authored
fix(windows-installer): ignore FilesInUse/Restart dialogue (runfinch#823)
Issue #, if available: - When upgrading Finch, if the VM is still running, an important looking screen mentioning "Files in use" will pop up, and prompt the user to have Finch try to delete these files, or ignore them. The default behavior of these options doesn't actually do anything in our case. Luckily, stopping Finch's VM and making sure its removed (which is done in the uninstall script) should take care of this for us instead. This change just removes the extra unnecessary step for users since it may be confusing. *Description of changes:* - Suppress the "Files in use" dialogue since it's confusing and not useful *Testing done:* - Simulated upgrades and uninstalls on my test machine - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]>
1 parent ace37ea commit f64835d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: msi-builder/FinchMSITemplate.wxs

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
<Feature Id="ProductFeature" Title="Finch" Level="1">
1313
<ComponentGroupRef Id="FinchComponents" />
1414
</Feature>
15+
<!-- Disable FilesInUse/Restart dialogue -->
16+
<Property Id="MSIRESTARTMANAGERCONTROL" Value="Disable" />
1517
<Directory Id="TARGETDIR" Name="SourceDir">
1618
<Directory Id="ProgramFiles64Folder">
1719
<Directory Id="INSTALLFOLDER" Name="Finch">

0 commit comments

Comments
 (0)