fix: Return empty network settings for non started containers

coderbirju · coderbirju · commit 9a879dcb6fb3 · 2025-03-17T01:47:01.000Z
Signed-off-by: Arjun Raja Yogidas &lt;arjunry@amazon.com&gt;
diff --git a/pkg/inspecttypes/dockercompat/dockercompat.go b/pkg/inspecttypes/dockercompat/dockercompat.go
@@ -458,6 +458,14 @@ func ContainerFromNative(n *native.Container) (*Container, error) {
 		}
 		c.NetworkSettings = nSettings
 		c.HostConfig.PortBindings = *nSettings.Ports
+	} else {
+		// n.process is not set if the container is not started, making the networkSetting null
+		// we should send an empty object even in this case inorder for it to be compatible with docker compse cli
+		nSettings, err := networkSettingsFromNative(nil, n.Spec.(*specs.Spec))
+		if err != nil {
+			return nil, err
+		}
+		c.NetworkSettings = nSettings
 	}
 
 	cpuSetting, err := cpuSettingsFromNative(n.Spec.(*specs.Spec))

Original file line number	Diff line number	Diff line change
`@@ -458,6 +458,14 @@ func ContainerFromNative(n native.Container) (Container, error) {`
`458`	`458`	`}`
`459`	`459`	`c.NetworkSettings = nSettings`
`460`	`460`	`c.HostConfig.PortBindings = *nSettings.Ports`
	`461`	`+ } else {`
	`462`	`+ // n.process is not set if the container is not started, making the networkSetting null`
	`463`	`+ // we should send an empty object even in this case inorder for it to be compatible with docker compse cli`
	`464`	`+ nSettings, err := networkSettingsFromNative(nil, n.Spec.(*specs.Spec))`
	`465`	`+ if err != nil {`
	`466`	`+ return nil, err`
	`467`	`+ }`
	`468`	`+ c.NetworkSettings = nSettings`
`461`	`469`	`}`
`462`	`470`
`463`	`471`	`cpuSetting, err := cpuSettingsFromNative(n.Spec.(*specs.Spec))`