Update workflow to run two benchmarks

This commit is a test to check if running both the benchmarks in the
same workflow would make any difference to the results

Upload and download benchmarks

Signed-off-by: Arjun Raja Yogidas <[email protected]>

Author: coderbirju

Diff for: .github/workflows/benchmark_regression_test.yml

@@ -28,48 +28,68 @@ jobs:
       - run: make
       - name: Run benchmark
         run: make benchmarks-perf-test
-      - name: Make previous directory
-        run: mkdir -v ${{ github.workspace }}/previous
-      - name: Copy results to previous directory
-        run: cp -r ${{ github.workspace }}/benchmark/performanceTest/output ${{ github.workspace }}/previous
+      - name: Upload latest benchmark result
+        uses: actions/upload-artifact@v3
+        with:
+          name: benchmark-result-artifact-main
+          path: ${{github.workspace}}/benchmark/performanceTest/output/results.json
+      - name: remove output directory
+        run:  sudo rm -rf ${{ github.workspace }}/benchmark/performanceTest/output
+      - name: Stash uncommitted changes
+        run: git stash push --keep-index --include-untracked -m "Stashing changes for tests"
       - name: Check out PR
         uses: actions/checkout@v3
         with:
           ref: ${{ github.event.pull_request.head.sha }}
       - run: make
       - name: Run benchmark
         run: make benchmarks-perf-test
-      - name: Make current directory
-        run: mkdir -v ${{ github.workspace }}/current
-      - name: Stash uncommitted changes
-        run: git stash push --keep-index --include-untracked -m "Stashing changes for tests"
-        # If you're using Git version 2.28 or later, use this line instead:
-        # run: git stash push --keep-index --include-untracked -m "Stashing changes for tests"
-        # This will ensure that uncommitted changes do not interfere with the tests.
-      - name: Copy results to current directory
-        run: cp -r ${{ github.workspace }}/benchmark/performanceTest/output ${{ github.workspace }}/current
-      - name: Perform Comparison and log results
-        id: run-compare
-        run: |
-            sudo chmod +x ${{ github.workspace }}/scripts/check_regression.sh
-            if sudo ${{ github.workspace }}/scripts/check_regression.sh ${{ github.workspace }}/previous/results.json ${{github.workspace}}/current/results.json; then
-              echo "Comparison successful. All P90 values are within the acceptable range."
-            else
-              echo "Comparison failed. Current P90 values exceed 110% of the corresponding past values."
-              echo "regression-detected=true" >> $GITHUB_OUTPUT
-            fi
-      - name: Stop the workflow if regression is detected
-        if: steps.run-compare.outputs.regression-detected == 'true'
-        uses: actions/github-script@v6
+      - name: Upload latest benchmark result
+        uses: actions/upload-artifact@v3
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const comment = `
-              :warning: **Regression Detected** :warning:
+          name: benchmark-result-artifact-pr
+          path: ${{github.workspace}}/benchmark/performanceTest/output/results.json
+
+  download_and_perform_comparison:
+        runs-on: ubuntu-20.04
+        needs: test-twice
+        steps:
+          - name: Make previous directory
+            run: mkdir -v ${{ github.workspace }}/previous
+          - name: Make current directory
+            run: mkdir -v ${{ github.workspace }}/current
+          - name: Download previous benchmark result
+            uses: actions/download-artifact@v3
+            with:
+              name: benchmark-result-artifact-main
+              path: ${{github.workspace}}/previous
+          - name: Download current benchmark result
+            uses: actions/download-artifact@v3
+            with:
+              name: benchmark-result-artifact-pr
+              path: ${{github.workspace}}/current
+          - name: Perform Comparison and log results
+            id: run-compare
+            run: |
+                sudo chmod +x ${{ github.workspace }}/scripts/check_regression.sh
+                if sudo ${{ github.workspace }}/scripts/check_regression.sh ${{ github.workspace }}/previous/benchmark-result-artifact-main/results.json ${{github.workspace}}/current/benchmark-result-artifact-pr/results.json; then
+                  echo "Comparison successful. All P90 values are within the acceptable range."
+                else
+                  echo "Comparison failed. Current P90 values exceed 110% of the corresponding past values."
+                  echo "regression-detected=true" >> $GITHUB_OUTPUT
+                fi
+          - name: Stop the workflow if regression is detected
+            if: steps.run-compare.outputs.regression-detected == 'true'
+            uses: actions/github-script@v6
+            with:
+              github-token: ${{ secrets.GITHUB_TOKEN }}
+              script: |
+                const comment = `
+                  :warning: **Regression Detected** :warning:
 
-              The benchmark comparison indicates that there has been a performance regression.
-              Please investigate and address the issue.
-              To Investigate check logs of the previous job above.
-            `;
+                  The benchmark comparison indicates that there has been a performance regression.
+                  Please investigate and address the issue.
+                  To Investigate check logs of the previous job above.
+                `;
 
-            core.setFailed(comment);
+                core.setFailed(comment);