fix

Author: lpereiracgn

cognite/client/data_classes/simulators/filters.py

@@ -8,10 +8,10 @@
 from cognite.client.utils.useful_types import SequenceNotStr
 
 
-def parse_str_or_sequence(value: str | Sequence[str] | None) -> list[str] | None:
+def _parse_str_or_sequence(value: str | SequenceNotStr[str] | None) -> list[str] | None:
     if isinstance(value, str):
         return [value]
-    elif isinstance(value, Sequence):
+    elif isinstance(value, SequenceNotStr):
         return list(value)
     return None
 
@@ -52,19 +52,19 @@ def __init__(
         self,
         status: str | None = None,
         run_type: str | None = None,
-        model_external_ids: str | Sequence[str] | None = None,
-        simulator_integration_external_ids: str | Sequence[str] | None = None,
-        simulator_external_ids: str | Sequence[str] | None = None,
-        routine_external_ids: str | Sequence[str] | None = None,
-        routine_revision_external_ids: str | Sequence[str] | None = None,
-        model_revision_external_ids: str | Sequence[str] | None = None,
+        model_external_ids: str | SequenceNotStr[str] | None = None,
+        simulator_integration_external_ids: str | SequenceNotStr[str] | None = None,
+        simulator_external_ids: str | SequenceNotStr[str] | None = None,
+        routine_external_ids: str | SequenceNotStr[str] | None = None,
+        routine_revision_external_ids: str | SequenceNotStr[str] | None = None,
+        model_revision_external_ids: str | SequenceNotStr[str] | None = None,
     ) -> None:
-        self.model_external_ids = [model_external_ids] if isinstance(model_external_ids, str) else model_external_ids
-        self.simulator_integration_external_ids = parse_str_or_sequence(simulator_integration_external_ids)
-        self.simulator_external_ids = parse_str_or_sequence(simulator_external_ids)
-        self.routine_external_ids = parse_str_or_sequence(routine_external_ids)
-        self.routine_revision_external_ids = parse_str_or_sequence(routine_revision_external_ids)
-        self.model_revision_external_ids = parse_str_or_sequence(model_revision_external_ids)
+        self.model_external_ids = _parse_str_or_sequence(model_external_ids)
+        self.simulator_integration_external_ids = _parse_str_or_sequence(simulator_integration_external_ids)
+        self.simulator_external_ids = _parse_str_or_sequence(simulator_external_ids)
+        self.routine_external_ids = _parse_str_or_sequence(routine_external_ids)
+        self.routine_revision_external_ids = _parse_str_or_sequence(routine_revision_external_ids)
+        self.model_revision_external_ids = _parse_str_or_sequence(model_revision_external_ids)
         self.status = status
         self.run_type = run_type
 

cognite/client/data_classes/simulators/runs.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, Literal
 
 from typing_extensions import Self
 
@@ -171,8 +171,8 @@ def __init__(
         model_revision_external_id: str,
         routine_revision_external_id: str,
         routine_external_id: str,
-        run_type: str,
-        status: str,
+        run_type: Literal["external", "manual", "scheduled"],
+        status: Literal["ready", "running", "success", "failure"],
         data_set_id: int,
         user_id: str,
         log_id: int,

tests/tests_integration/test_api/test_simulators/test_runs.py

@@ -53,5 +53,6 @@ def test_create_run(
                 )
             ]
         )
+        assert len(created_runs) == 1
         assert created_runs[0].routine_external_id == routine_external_id
         assert created_runs[0].id is not None