Skip to content

Commit 9653e9d

Browse files
committed
fix
1 parent dda9998 commit 9653e9d

File tree

2 files changed

+10
-11
lines changed
  • cognite/client/_api/simulators
  • tests/tests_integration/test_api/test_simulators

2 files changed

+10
-11
lines changed

cognite/client/_api/simulators/runs.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class SimulatorRunsAPI(APIClient):
2121

2222
def __init__(self, config: ClientConfig, api_version: str | None, cognite_client: CogniteClient) -> None:
2323
super().__init__(config, api_version, cognite_client)
24+
self._CREATE_LIMIT = 1
2425
self._warning = FeaturePreviewWarning(
2526
api_maturity="General Availability", sdk_maturity="alpha", feature_name="Simulators"
2627
)
@@ -48,7 +49,7 @@ def __call__(
4849
routine_external_ids: Sequence[str] | None = None,
4950
routine_revision_external_ids: Sequence[str] | None = None,
5051
model_revision_external_ids: Sequence[str] | None = None,
51-
) -> Iterator[SimulationRun]: ...
52+
) -> Iterator[SimulatorRunsList]: ...
5253

5354
@overload
5455
def __call__(

tests/tests_integration/test_api/test_simulators/test_runs.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ def test_create_run(
2323

2424
def test_list_filtering(self, cognite_client: CogniteClient, seed_resource_names) -> None:
2525
routine_external_id = seed_resource_names["simulator_routine_external_id"]
26-
status = ["running", "success", "failure"]
27-
for _ in range(3):
26+
runs_filtered_by_status = []
27+
for current_status in ["running", "success", "failure"]:
2828
created_runs = cognite_client.simulators.runs.create(
2929
[
3030
SimulationRunWrite(
@@ -33,26 +33,24 @@ def test_list_filtering(self, cognite_client: CogniteClient, seed_resource_names
3333
)
3434
]
3535
)
36-
assert created_runs[0].routine_external_id == routine_external_id
37-
status_to_be_set = status.pop(0)
3836

3937
cognite_client.simulators._post(
4038
"/simulators/run/callback",
4139
json={
4240
"items": [
4341
{
4442
"id": created_runs[0].id,
45-
"status": status_to_be_set,
43+
"status": current_status,
4644
}
4745
]
4846
},
4947
)
5048

5149
filter_by_status = cognite_client.simulators.runs.list(
52-
status=status_to_be_set, routine_external_ids=[routine_external_id]
50+
status=current_status, routine_external_ids=[routine_external_id]
5351
)
54-
assert filter_by_status[0].status == status_to_be_set
55-
assert filter_by_status[0].id == created_runs[0].id
52+
runs_filtered_by_status.append(filter_by_status[0].dump())
5653

57-
filter_by_routine = cognite_client.simulators.runs.list(routine_external_ids=[routine_external_id])
58-
assert len(filter_by_routine) >= 3
54+
filter_by_routine = cognite_client.simulators.runs.list(routine_external_ids=[routine_external_id]).dump()
55+
for run in runs_filtered_by_status:
56+
assert run in filter_by_routine

0 commit comments

Comments
 (0)