RUBY-2706 Test find related options (mongodb#2789)

* 2706

* Add unified test for all find options

* Add missing options

* Clarify collation on collection

* Add tests for read_concern option

* Add tests for read_preference option

Author: comandeo-mongo

lib/mongo/collection.rb

@@ -339,7 +339,9 @@ def capped?
     #     inserted or updated documents where the clustered index key value
     #     matches an existing value in the index.
     #   - *:name* -- Optional. A name that uniquely identifies the clustered index.
-    # @option opts [ Hash ] :collation The collation to use.
+    # @option opts [ Hash ] :collation The collation to use when creating the
+    #   collection. This option will not be sent to the server when calling
+    #   collection methods.
     # @option opts [ Hash ] :encrypted_fields Hash describing encrypted fields
     #   for queryable encryption.
     # @option opts [ Integer ] :expire_after Number indicating

lib/mongo/collection/view/iterable.rb

@@ -162,6 +162,7 @@ def initial_query_op(session)
             let: options[:let],
             limit: limit,
             allow_disk_use: options[:allow_disk_use],
+            allow_partial_results: options[:allow_partial_results],
             read: read,
             read_concern: options[:read_concern] || read_concern,
             batch_size: batch_size,

spec/integration/find_options_spec.rb

@@ -13,20 +13,10 @@
     [ SpecConfig.instance.addresses.first ]
   end
 
-  let(:client_options) do
-    {}
-  end
-
-  let(:collection_options) do
-    {}
-  end
-
   let(:client) do
     ClientRegistry.instance.new_local_client(
       seeds,
-      SpecConfig.instance.test_options
-        .merge(database: SpecConfig.instance.test_db)
-        .merge(client_options)
+      SpecConfig.instance.test_options.merge(client_options)
     ).tap do |client|
       client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
     end
@@ -40,11 +30,8 @@
     subscriber.started_events.find { |cmd| cmd.command_name == 'find' }
   end
 
-  let(:should_create_collection) { true }
-
   before do
-    client['find_options'].drop
-    collection.create if should_create_collection
+    ClientRegistry.instance.global_client('authorized')['find_options'].drop
     collection.insert_many([ { a: 1 }, { a: 2 }, { a: 3 } ])
   end
 
@@ -84,8 +71,6 @@
         { 'locale' => 'de_AT' }
       end
 
-      let(:should_create_collection) { false }
-
       it 'uses the collation defined on the collection' do
         collection.find({}, collation: collation).to_a
         expect(find_command.command['collation']).to eq(collation)
@@ -202,26 +187,4 @@
       end
     end
   end
-
-  describe 'cursor type' do
-    let(:collection_options) do
-      { capped: true, size: 1000 }
-    end
-
-    context 'when cursor type is :tailable' do
-      it 'sets the cursor type to tailable' do
-        collection.find({}, cursor_type: :tailable).first
-        expect(find_command.command['tailable']).to be true
-        expect(find_command.command['awaitData']).to be_falsey
-      end
-    end
-
-    context 'when cursor type is :tailable_await' do
-      it 'sets the cursor type to tailable' do
-        collection.find({}, cursor_type: :tailable_await).first
-        expect(find_command.command['tailable']).to be true
-        expect(find_command.command['awaitData']).to be true
-      end
-    end
-  end
 end

spec/runners/unified/crud_operations.rb

@@ -32,6 +32,18 @@ def get_find_view(op)
         if session = args.use('session')
           opts[:session] = entities.get(:session, session)
         end
+        if collation = args.use('collation')
+          opts[:collation] = collation
+        end
+        if args.key?('noCursorTimeout')
+          opts[:no_cursor_timeout] = args.use('noCursorTimeout')
+        end
+        if args.key?('oplogReplay')
+          opts[:oplog_replay] = args.use('oplogReplay')
+        end
+        if args.key?('allowPartialResults')
+          opts[:allow_partial_results] = args.use('allowPartialResults')
+        end
         req = collection.find(args.use!('filter'), **opts)
         if batch_size = args.use('batchSize')
           req = req.batch_size(batch_size)