[OPIK-1354] add span type guardrail (#1726)

* OPIK-1354 add span type guardrail

* OPIK-1354 removed rollback

* OPIK-1354 rename migration script

* Updated migration changeset to 16

* Fix in 16 version

---------

Co-authored-by: Andres Cruz <[email protected]>

Author: idoberko2

apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java

@@ -240,7 +240,7 @@ INSERT INTO spans(
                     :trace_id as trace_id,
                     :parent_span_id as parent_span_id,
                     :name as name,
-                    CAST(:type, 'Enum8(\\'unknown\\' = 0 , \\'general\\' = 1, \\'tool\\' = 2, \\'llm\\' = 3)') as type,
+                    CAST(:type, 'Enum8(\\'unknown\\' = 0 , \\'general\\' = 1, \\'tool\\' = 2, \\'llm\\' = 3, \\'guardrail\\' = 4)') as type,
                     parseDateTime64BestEffort(:start_time, 9) as start_time,
                     <if(end_time)> parseDateTime64BestEffort(:end_time, 9) as end_time, <else> null as end_time, <endif>
                     :input as input,

apps/opik-backend/src/main/java/com/comet/opik/domain/SpanType.java

@@ -7,6 +7,7 @@ public enum SpanType {
     general,
     tool,
     llm,
+    guardrail,
     ;
 
     public static SpanType fromString(String value) {

apps/opik-backend/src/main/resources/liquibase/db-app-analytics/migrations/000016_guardrails_span_type.sql

@@ -0,0 +1,11 @@
+--liquibase formatted sql
+--changeset idoberko2:000016_guardrails_span_type
+
+
+ALTER TABLE ${ANALYTICS_DB_DATABASE_NAME}.spans MODIFY COLUMN type Enum8(
+    'unknown' = 0 ,
+    'general' = 1,
+    'tool' = 2,
+    'llm' = 3,
+    'guardrail' = 4);
+

apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/SpansResourceTest.java

@@ -108,6 +108,7 @@
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Comparator;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -1362,8 +1363,9 @@ void createAndGetByProjectNameAndTraceId() {
                     List.of());
         }
 
-        @Test
-        void createAndGetByProjectIdAndTraceIdAndType() {
+        @ParameterizedTest
+        @EnumSource(SpanType.class)
+        void createAndGetByProjectIdAndTraceIdAndType(SpanType expectedType) {
             String workspaceName = UUID.randomUUID().toString();
             String workspaceId = UUID.randomUUID().toString();
             String apiKey = UUID.randomUUID().toString();
@@ -1379,7 +1381,7 @@ void createAndGetByProjectIdAndTraceIdAndType() {
                             .parentSpanId(null)
                             .projectName(projectName)
                             .traceId(traceId)
-                            .type(SpanType.llm)
+                            .type(expectedType)
                             .feedbackScores(null)
                             .build())
                     .toList();
@@ -1396,7 +1398,7 @@ void createAndGetByProjectIdAndTraceIdAndType() {
                     .projectName(projectName)
                     .traceId(traceId)
                     .parentSpanId(null)
-                    .type(SpanType.general)
+                    .type(findOtherSpanType(expectedType))
                     .build());
             unexpectedSpans.forEach(
                     expectedSpan -> SpansResourceTest.this.createAndAssert(expectedSpan, apiKey, workspaceName));
@@ -1406,7 +1408,7 @@ void createAndGetByProjectIdAndTraceIdAndType() {
                     null,
                     projectId,
                     traceId,
-                    SpanType.llm,
+                    expectedType,
                     null,
                     1,
                     pageSize,
@@ -1420,7 +1422,7 @@ void createAndGetByProjectIdAndTraceIdAndType() {
                     null,
                     projectId,
                     traceId,
-                    SpanType.llm,
+                    expectedType,
                     null,
                     2,
                     pageSize,
@@ -1431,6 +1433,11 @@ void createAndGetByProjectIdAndTraceIdAndType() {
                     List.of());
         }
 
+        private SpanType findOtherSpanType(SpanType expectedType) {
+            return Arrays.stream(SpanType.values()).filter(type -> type != expectedType).findFirst()
+                    .orElseThrow(() -> new IllegalArgumentException("expected to find another span type"));
+        }
+
         @ParameterizedTest
         @ValueSource(booleans = {true, false})
         void whenUsingPagination__thenReturnTracesPaginated(boolean stream) {
@@ -6338,11 +6345,9 @@ private static int randomNumber(int minValue, int maxValue) {
     class GetFeedbackScoreNames {
 
         Stream<Arguments> getFeedbackScoreNames__whenGetFeedbackScoreNames__thenReturnFeedbackScoreNames() {
-            return Stream.of(
-                    arguments(Optional.empty()),
-                    arguments(Optional.of(SpanType.llm)),
-                    arguments(Optional.of(SpanType.general)),
-                    arguments(Optional.of(SpanType.tool)));
+            return Stream.concat(
+                    Stream.of(arguments(Optional.empty())),
+                    Arrays.stream(SpanType.values()).map(type -> arguments(Optional.of(type))));
         }
 
         @ParameterizedTest