Skip to content

Commit 0353ef2

Browse files
authored
Merge pull request #18 from comet-ml/mysql8
Switch to MySQL 8 as default in RDS
2 parents aabc737 + b48e3d7 commit 0353ef2

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

modules/comet_rds/main.tf

+6-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ resource "aws_rds_cluster" "cometml-db-cluster" {
4646

4747
resource "aws_rds_cluster_parameter_group" "cometml-cluster-pg" {
4848
name = "cometml-rds-cluster-pg-${var.environment}"
49-
family = "aurora-mysql5.7"
49+
family = "aurora-mysql${var.rds_engine_version}"
5050
description = "CometML RDS cluster parameter group"
5151

5252
parameter {
@@ -109,6 +109,11 @@ resource "aws_rds_cluster_parameter_group" "cometml-cluster-pg" {
109109
name = "log_bin_trust_function_creators"
110110
value = "1"
111111
}
112+
parameter {
113+
apply_method = "pending-reboot"
114+
name = "thread_stack"
115+
value = "6291456"
116+
}
112117
}
113118

114119
resource "aws_security_group" "mysql_sg" {

variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ variable "rds_engine" {
278278
variable "rds_engine_version" {
279279
description = "Engine version number for RDS database"
280280
type = string
281-
default = "5.7"
281+
default = "8.0"
282282
}
283283

284284
variable "rds_instance_type" {

0 commit comments

Comments
 (0)