refactor constants name with uppercased ones

Signed-off-by: parneet-guraya <[email protected]>

Author: parneet-guraya

app/src/main/java/fr/free/nrw/commons/CommonsApplication.kt

@@ -306,10 +306,10 @@ class CommonsApplication : MultiDexApplication() {
                 .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
 
             if (loginMessage != null) {
-                loginIntent.putExtra(loginMessageIntentKey, loginMessage)
+                loginIntent.putExtra(LOGIN_MESSAGE_INTENT_KEY, loginMessage)
             }
             if (userName != null) {
-                loginIntent.putExtra(loginUsernameIntentKey, userName)
+                loginIntent.putExtra(LOGIN_USERNAME_INTENT_KEY, userName)
             }
 
             ctx.startActivity(loginIntent)
@@ -356,9 +356,9 @@ class CommonsApplication : MultiDexApplication() {
     }
 
     companion object {
-        //TODO should be uppercase
-        const val loginMessageIntentKey: String = "loginMessage"
-        const val loginUsernameIntentKey: String = "loginUsername"
+
+        const val LOGIN_MESSAGE_INTENT_KEY: String = "loginMessage"
+        const val LOGIN_USERNAME_INTENT_KEY: String = "loginUsername"
 
         const val IS_LIMITED_CONNECTION_MODE_ENABLED: String = "is_limited_connection_mode_enabled"
 

app/src/main/java/fr/free/nrw/commons/auth/LoginActivity.java

@@ -50,8 +50,8 @@
 import static android.view.KeyEvent.KEYCODE_ENTER;
 import static android.view.View.VISIBLE;
 import static android.view.inputmethod.EditorInfo.IME_ACTION_DONE;
-import static fr.free.nrw.commons.CommonsApplication.loginMessageIntentKey;
-import static fr.free.nrw.commons.CommonsApplication.loginUsernameIntentKey;
+import static fr.free.nrw.commons.CommonsApplication.LOGIN_MESSAGE_INTENT_KEY;
+import static fr.free.nrw.commons.CommonsApplication.LOGIN_USERNAME_INTENT_KEY;
 
 public class LoginActivity extends AccountAuthenticatorActivity {
 
@@ -94,8 +94,8 @@ public void onCreate(Bundle savedInstanceState) {
         binding = ActivityLoginBinding.inflate(getLayoutInflater());
         setContentView(binding.getRoot());
 
-        String message = getIntent().getStringExtra(loginMessageIntentKey);
-        String username = getIntent().getStringExtra(loginUsernameIntentKey);
+        String message = getIntent().getStringExtra(LOGIN_MESSAGE_INTENT_KEY);
+        String username = getIntent().getStringExtra(LOGIN_USERNAME_INTENT_KEY);
 
         binding.loginUsername.addTextChangedListener(textWatcher);
         binding.loginPassword.addTextChangedListener(textWatcher);