Change item background according to the theme (#3480)

* Change item  background according to the theme

* Change background colour of item on being selected

* Change background colors using XML selectors

Author: gupta-anmol

app/src/main/java/fr/free/nrw/commons/nearby/NearbyFilterSearchRecyclerViewAdapter.java

@@ -70,7 +70,7 @@ public RecyclerViewHolder(View view) {
     @NonNull
     @Override
     public RecyclerViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        View itemView = inflater.inflate(callback.isDarkTheme()?R.layout.nearby_search_list_item_dark:R.layout.nearby_search_list_item, parent, false);
+        View itemView = inflater.inflate(callback.isDarkTheme() ? R.layout.nearby_search_list_item_dark : R.layout.nearby_search_list_item, parent, false);
         return new RecyclerViewHolder(itemView);
     }
 
@@ -79,17 +79,20 @@ public void onBindViewHolder(@NonNull RecyclerViewHolder holder, int position) {
         Label label = displayedLabels.get(position);
         holder.placeTypeIcon.setImageResource(label.getIcon());
         holder.placeTypeLabel.setText(label.toString());
+        holder.placeTypeLayout.setSelected(label.isSelected());
 
-        holder.placeTypeLayout.setBackgroundColor(label.isSelected() ? ContextCompat.getColor(context, R.color.divider_grey) : callback.isDarkTheme()?Color.BLACK:Color.WHITE);
         holder.placeTypeLayout.setOnClickListener(view -> {
             callback.setCheckboxUnknown();
+
             if (label.isSelected()) {
                 selectedLabels.remove(label);
             } else {
                 selectedLabels.add(label);
             }
+
             label.setSelected(!label.isSelected());
-            holder.placeTypeLayout.setBackgroundColor(label.isSelected() ? ContextCompat.getColor(context, R.color.divider_grey) : Color.WHITE);
+            holder.placeTypeLayout.setSelected(label.isSelected());
+
             callback.filterByMarkerType(selectedLabels, 0, false, false);
         });
     }
@@ -165,7 +168,7 @@ public void setRecyclerViewAdapterAllSelected() {
         notifyDataSetChanged();
     }
 
-    public interface  Callback{
+    public interface  Callback {
 
         void setCheckboxUnknown();
 

app/src/main/res/drawable/linearlayout_color_dark_selector.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item android:state_selected="true"
+        android:drawable="@color/opak_middle_grey" />
+    <item android:drawable="@color/black" />
+</selector>

app/src/main/res/drawable/linearlayout_color_selector.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item android:state_selected="true"
+        android:drawable="@color/divider_grey" />
+    <item android:drawable="@color/white" />
+</selector>

app/src/main/res/layout/nearby_search_list_item.xml

@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
+
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:id="@+id/search_list_item"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:orientation="horizontal"
-    android:padding="@dimen/tiny_margin">
+    android:padding="@dimen/tiny_margin"
+    android:background="@drawable/linearlayout_color_selector">
 
     <ImageView
         android:id="@+id/place_icon"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content" />
+        android:layout_height="wrap_content"/>
 
     <TextView
         android:id="@+id/place_text"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"></TextView>
+        android:layout_height="wrap_content"/>
 </LinearLayout>

app/src/main/res/layout/nearby_search_list_item_dark.xml

@@ -4,16 +4,17 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:padding="@dimen/tiny_margin"
-    android:orientation="horizontal">
+    android:orientation="horizontal"
+    android:background="@drawable/linearlayout_color_dark_selector">
 
     <ImageView
         android:id="@+id/place_icon"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content" />
+        android:layout_height="wrap_content"/>
 
     <TextView
         android:id="@+id/place_text"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:textColor="@color/white"></TextView>
+        android:textColor="@color/white"/>
 </LinearLayout>