make prop nullable (#6073)

parneet-guraya · web-flow · commit 86cdf96f3d42 · 2024-12-25T00:55:12.000+09:00
Signed-off-by: parneet-guraya &lt;gurayaparneet@gmail.com&gt;
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadBaseFragment.kt b/app/src/main/java/fr/free/nrw/commons/upload/UploadBaseFragment.kt
@@ -6,7 +6,7 @@ import fr.free.nrw.commons.di.CommonsDaggerSupportFragment
  * The base fragment of the fragments in upload
  */
 abstract class UploadBaseFragment : CommonsDaggerSupportFragment() {
-    lateinit var callback: Callback
+    var callback: Callback? = null
 
     protected open fun onBecameVisible() = Unit
 
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.kt b/app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.kt
@@ -96,10 +96,10 @@ class UploadCategoriesFragment : UploadBaseFragment(), CategoriesContract.View {
         if (media == null) {
             if (callback != null) {
                 binding!!.tvTitle.text = getString(
-                    R.string.step_count, callback.getIndexInViewFlipper(
+                    R.string.step_count, callback!!.getIndexInViewFlipper(
                         this
                     ) + 1,
-                    callback.totalNumberOfSteps, getString(R.string.categories_activity_title)
+                    callback!!.totalNumberOfSteps, getString(R.string.categories_activity_title)
                 )
             }
         } else {
@@ -220,7 +220,7 @@ class UploadCategoriesFragment : UploadBaseFragment(), CategoriesContract.View {
     }
 
     override fun goToNextScreen() {
-        callback.onNextButtonClicked(callback.getIndexInViewFlipper(this))
+        callback!!.onNextButtonClicked(callback!!.getIndexInViewFlipper(this))
     }
 
     override fun showNoCategorySelected() {
@@ -322,7 +322,7 @@ class UploadCategoriesFragment : UploadBaseFragment(), CategoriesContract.View {
             mediaDetailFragment.onResume()
             goBackToPreviousScreen()
         } else {
-            callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this))
+            callback!!.onPreviousButtonClicked(callback!!.getIndexInViewFlipper(this))
         }
     }
 
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.kt b/app/src/main/java/fr/free/nrw/commons/upload/depicts/DepictsFragment.kt
@@ -97,10 +97,10 @@ class DepictsFragment : UploadBaseFragment(), DepictsContract.View {
         if (media == null) {
             binding.depictsTitle.text =
                 String.format(
-                    getString(R.string.step_count), callback.getIndexInViewFlipper(
+                    getString(R.string.step_count), callback!!.getIndexInViewFlipper(
                         this
                     ) + 1,
-                    callback.totalNumberOfSteps, getString(R.string.depicts_step_title)
+                    callback!!.totalNumberOfSteps, getString(R.string.depicts_step_title)
                 )
         } else {
             binding.depictsTitle.setText(R.string.edit_depictions)
@@ -173,11 +173,11 @@ class DepictsFragment : UploadBaseFragment(), DepictsContract.View {
     }
 
     override fun goToNextScreen() {
-        callback.onNextButtonClicked(callback.getIndexInViewFlipper(this))
+        callback!!.onNextButtonClicked(callback!!.getIndexInViewFlipper(this))
     }
 
     override fun goToPreviousScreen() {
-        callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this))
+        callback!!.onPreviousButtonClicked(callback!!.getIndexInViewFlipper(this))
     }
 
     override fun noDepictionSelected() {
@@ -338,7 +338,7 @@ class DepictsFragment : UploadBaseFragment(), DepictsContract.View {
             updateDepicts()
             goBackToPreviousScreen()
         } else {
-            callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this))
+            callback!!.onPreviousButtonClicked(callback!!.getIndexInViewFlipper(this))
         }
     }
 
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/license/MediaLicenseFragment.kt b/app/src/main/java/fr/free/nrw/commons/upload/license/MediaLicenseFragment.kt
@@ -47,20 +47,20 @@ class MediaLicenseFragment : UploadBaseFragment(), MediaLicenseContract.View {
 
         binding.tvTitle.text = getString(
             R.string.step_count,
-            callback.getIndexInViewFlipper(this) + 1,
-            callback.totalNumberOfSteps,
+            callback!!.getIndexInViewFlipper(this) + 1,
+            callback!!.totalNumberOfSteps,
             getString(R.string.license_step_title)
         )
         setTvSubTitle()
         binding.btnPrevious.setOnClickListener {
-            callback.onPreviousButtonClicked(
-                callback.getIndexInViewFlipper(this)
+            callback!!.onPreviousButtonClicked(
+                callback!!.getIndexInViewFlipper(this)
             )
         }
 
         binding.btnSubmit.setOnClickListener {
-            callback.onNextButtonClicked(
-                callback.getIndexInViewFlipper(this)
+            callback!!.onNextButtonClicked(
+                callback!!.getIndexInViewFlipper(this)
             )
         }
 
@@ -201,6 +201,6 @@ class MediaLicenseFragment : UploadBaseFragment(), MediaLicenseContract.View {
          * Show the wlm info message if the upload is a WLM upload
          */
         binding.llInfoMonumentUpload.visibility =
-            if (callback.isWLMUpload && presenter.isWLMSupportedForThisPlace()) View.VISIBLE else View.GONE
+            if (callback!!.isWLMUpload && presenter.isWLMSupportedForThisPlace()) View.VISIBLE else View.GONE
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -96,10 +96,10 @@ class UploadCategoriesFragment : UploadBaseFragment(), CategoriesContract.View {`
`96`	`96`	`if (media == null) {`
`97`	`97`	`if (callback != null) {`
`98`	`98`	`binding!!.tvTitle.text = getString(`
`99`		`- R.string.step_count, callback.getIndexInViewFlipper(`
	`99`	`+ R.string.step_count, callback!!.getIndexInViewFlipper(`
`100`	`100`	`this`
`101`	`101`	`) + 1,`
`102`		`- callback.totalNumberOfSteps, getString(R.string.categories_activity_title)`
	`102`	`+ callback!!.totalNumberOfSteps, getString(R.string.categories_activity_title)`
`103`	`103`	`)`
`104`	`104`	`}`
`105`	`105`	`} else {`
`@@ -220,7 +220,7 @@ class UploadCategoriesFragment : UploadBaseFragment(), CategoriesContract.View {`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`override fun goToNextScreen() {`
`223`		`- callback.onNextButtonClicked(callback.getIndexInViewFlipper(this))`
	`223`	`+ callback!!.onNextButtonClicked(callback!!.getIndexInViewFlipper(this))`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`override fun showNoCategorySelected() {`
`@@ -322,7 +322,7 @@ class UploadCategoriesFragment : UploadBaseFragment(), CategoriesContract.View {`
`322`	`322`	`mediaDetailFragment.onResume()`
`323`	`323`	`goBackToPreviousScreen()`
`324`	`324`	`} else {`
`325`		`- callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this))`
	`325`	`+ callback!!.onPreviousButtonClicked(callback!!.getIndexInViewFlipper(this))`
`326`	`326`	`}`
`327`	`327`	`}`
`328`	`328`
Original file line number	Diff line number	Diff line change
`@@ -97,10 +97,10 @@ class DepictsFragment : UploadBaseFragment(), DepictsContract.View {`
`97`	`97`	`if (media == null) {`
`98`	`98`	`binding.depictsTitle.text =`
`99`	`99`	`String.format(`
`100`		`- getString(R.string.step_count), callback.getIndexInViewFlipper(`
	`100`	`+ getString(R.string.step_count), callback!!.getIndexInViewFlipper(`
`101`	`101`	`this`
`102`	`102`	`) + 1,`
`103`		`- callback.totalNumberOfSteps, getString(R.string.depicts_step_title)`
	`103`	`+ callback!!.totalNumberOfSteps, getString(R.string.depicts_step_title)`
`104`	`104`	`)`
`105`	`105`	`} else {`
`106`	`106`	`binding.depictsTitle.setText(R.string.edit_depictions)`
`@@ -173,11 +173,11 @@ class DepictsFragment : UploadBaseFragment(), DepictsContract.View {`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`override fun goToNextScreen() {`
`176`		`- callback.onNextButtonClicked(callback.getIndexInViewFlipper(this))`
	`176`	`+ callback!!.onNextButtonClicked(callback!!.getIndexInViewFlipper(this))`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`override fun goToPreviousScreen() {`
`180`		`- callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this))`
	`180`	`+ callback!!.onPreviousButtonClicked(callback!!.getIndexInViewFlipper(this))`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`override fun noDepictionSelected() {`
`@@ -338,7 +338,7 @@ class DepictsFragment : UploadBaseFragment(), DepictsContract.View {`
`338`	`338`	`updateDepicts()`
`339`	`339`	`goBackToPreviousScreen()`
`340`	`340`	`} else {`
`341`		`- callback.onPreviousButtonClicked(callback.getIndexInViewFlipper(this))`
	`341`	`+ callback!!.onPreviousButtonClicked(callback!!.getIndexInViewFlipper(this))`
`342`	`342`	`}`
`343`	`343`	`}`
`344`	`344`
Original file line number	Diff line number	Diff line change
`@@ -47,20 +47,20 @@ class MediaLicenseFragment : UploadBaseFragment(), MediaLicenseContract.View {`
`47`	`47`
`48`	`48`	`binding.tvTitle.text = getString(`
`49`	`49`	`R.string.step_count,`
`50`		`- callback.getIndexInViewFlipper(this) + 1,`
`51`		`- callback.totalNumberOfSteps,`
	`50`	`+ callback!!.getIndexInViewFlipper(this) + 1,`
	`51`	`+ callback!!.totalNumberOfSteps,`
`52`	`52`	`getString(R.string.license_step_title)`
`53`	`53`	`)`
`54`	`54`	`setTvSubTitle()`
`55`	`55`	`binding.btnPrevious.setOnClickListener {`
`56`		`- callback.onPreviousButtonClicked(`
`57`		`- callback.getIndexInViewFlipper(this)`
	`56`	`+ callback!!.onPreviousButtonClicked(`
	`57`	`+ callback!!.getIndexInViewFlipper(this)`
`58`	`58`	`)`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`binding.btnSubmit.setOnClickListener {`
`62`		`- callback.onNextButtonClicked(`
`63`		`- callback.getIndexInViewFlipper(this)`
	`62`	`+ callback!!.onNextButtonClicked(`
	`63`	`+ callback!!.getIndexInViewFlipper(this)`
`64`	`64`	`)`
`65`	`65`	`}`
`66`	`66`
`@@ -201,6 +201,6 @@ class MediaLicenseFragment : UploadBaseFragment(), MediaLicenseContract.View {`
`201`	`201`	`* Show the wlm info message if the upload is a WLM upload`
`202`	`202`	`*/`
`203`	`203`	`binding.llInfoMonumentUpload.visibility =`
`204`		`- if (callback.isWLMUpload && presenter.isWLMSupportedForThisPlace()) View.VISIBLE else View.GONE`
	`204`	`+ if (callback!!.isWLMUpload && presenter.isWLMSupportedForThisPlace()) View.VISIBLE else View.GONE`
`205`	`205`	`}`
`206`	`206`	`}`