use lateinit instead of nullable incase there's a promise of being initialized

Signed-off-by: parneet-guraya <[email protected]>

Author: parneet-guraya

app/src/androidTest/java/fr/free/nrw/commons/AboutActivityTest.kt

@@ -105,7 +105,7 @@ class AboutActivityTest {
     fun testLaunchTranslate() {
         Espresso.onView(ViewMatchers.withId(R.id.about_translate)).perform(ViewActions.click())
         Espresso.onView(ViewMatchers.withId(android.R.id.button1)).perform(ViewActions.click())
-        val langCode = CommonsApplication.instance!!.languageLookUpTable!!.codes[0]
+        val langCode = CommonsApplication.instance.languageLookUpTable.codes[0]
         Intents.intended(
             CoreMatchers.allOf(
                 IntentMatchers.hasAction(Intent.ACTION_VIEW),

app/src/main/java/fr/free/nrw/commons/CommonsApplication.kt

@@ -85,7 +85,7 @@ class CommonsApplication : MultiDexApplication() {
     @Inject
     lateinit var customOkHttpNetworkFetcher: CustomOkHttpNetworkFetcher
 
-    var languageLookUpTable: AppLanguageLookUpTable? = null
+    lateinit var languageLookUpTable: AppLanguageLookUpTable
         private set
 
     @Inject
@@ -386,7 +386,7 @@ class CommonsApplication : MultiDexApplication() {
          */
 
         @JvmStatic
-        var instance: CommonsApplication? = null
+        lateinit var instance: CommonsApplication
             private set
 
         @JvmField

app/src/main/java/fr/free/nrw/commons/actions/ThanksClient.kt

@@ -32,7 +32,7 @@ class ThanksClient
                         revisionId.toString(), // Rev
                         null, // Log
                         csrfTokenClient.getTokenBlocking(), // Token
-                        CommonsApplication.instance!!.userAgent, // Source
+                        CommonsApplication.instance.userAgent, // Source
                     ).map { mwThankPostResponse ->
                         mwThankPostResponse.result?.success == 1
                     }

app/src/main/java/fr/free/nrw/commons/upload/worker/UploadWorker.kt

@@ -438,7 +438,7 @@ class UploadWorker(
                                 username,
                             )
                         CommonsApplication
-                            .instance!!
+                            .instance
                             .clearApplicationData(appContext, logoutListener)
                     }
                 }