Skip to content

Code quality: make contributions and featured activity use same code #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neslihanturan opened this issue May 29, 2018 · 3 comments
Open

Comments

@neslihanturan
Copy link
Collaborator

Summary:

Currently Contributions Activity and Featured Activity includes several copy pasted codes. They should be organized by inheritance

Would you like to work on the issue?

In two weeks, yes

@maskaravivek
Copy link
Member

Yes, ideally contributions activity and featured activity could share a lot of code. Just the data source would be different, other than that the UI rendering, scrolling logic and list adapter logic can be shared.

It would be great to pick up this cleanup as more and more browsing features are being added.

@misaochan
Copy link
Member

Agreed, this would be useful.

@chrisdebian
Copy link

Have we got anybody currently contributing to the project, that is interested in code quality, and could potentially look at (refactor?) this?

Chris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants