Skip to content

Replace BiMap with a HashMap #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
macgills opened this issue Mar 12, 2020 · 2 comments · Fixed by #3572
Closed

Replace BiMap with a HashMap #3498

macgills opened this issue Mar 12, 2020 · 2 comments · Fixed by #3572
Assignees
@gupta-anmol

Comments

@macgills
Copy link
Contributor

Summary:

BiMap is unnecessary and can be deleted, contansKey(V v) is replaceable by containsValue
@gupta-anmol
Copy link
Contributor

gupta-anmol commented Mar 20, 2020 •
edited
Loading

@macgills Can I work on this?

I have identified the following changes that will have to be made:

  1. Change BiMap to HashMap in DescriptionsAdapter.java
  2. Change BiMap to HashMap in SpinnerLanguagesAdapter.kt
  3. Delete BiMap.java (I am not sure, maybe we can keep it)

I didn't find any usage of containsKey(V v), so I don't think there's any issues here.

@macgills
Copy link
Contributor Author

There is one instance where you will have to use containsValue I think. Please delete BiMap in your PR

@gupta-anmol gupta-anmol mentioned this issue Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gupta-anmol gupta-anmol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change BiMap to HashMap gupta-anmol/apps-android-commons
2 participants
@macgills @gupta-anmol