Skip to content

[Bug]: Only one category shows for a depicted item if it has several values on P373 #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ainali opened this issue Mar 15, 2022 · 12 comments

Comments

@Ainali
Copy link

Ainali commented Mar 15, 2022

Summary

I noticed on Q636666 that it did not show the category I expected. It turns out that it has two values on P373 and the one that unfortunately is hard to interpret for me is chosen in the app.

Steps to reproduce

  1. Upload an image
  2. In depicts, select an item with several values on P373
  3. In categories, see that only one of them is shown

Expected behaviour

I would like to see all values as suggested categories.

Actual behaviour

The app suggests one of the categories, not all.

Device name

Samsung Galaxy S10

Android version

Android 12

Commons app version

3.1.1~1c9267ca0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

No response

@nicolas-raoul
Copy link
Member

Interestingly the DepictedItem class already has commonsCategories: List<CategoryItem>, we should verify that:

  • It is filled correctly
  • We surface all of its elements as suggestions, not just the first element.

@Ainali
Copy link
Author

Ainali commented Mar 16, 2022

I made this screencast:

20220316_090752.mp4

Interestingly it shows a category Ventura (ship), which doesn't exist. The name of the other category on Wikidata which exists on Commons, and the one I expected, is Ventura (ship, 2008).

@nicolas-raoul nicolas-raoul changed the title [Bug]: Only one category shows for a depicted item if it have several values on P373 [Bug]: Only one category shows for a depicted item if it has several values on P373 Dec 31, 2023
@zihanpan
Copy link
Contributor

zihanpan commented Oct 8, 2024

Hi, I’m part of a group of 4 working on a university assignment. Could we please be assigned this issue to work on?

@nicolas-raoul
Copy link
Member

@zihanpan It is yours, thanks! :-)

@zihanpan
Copy link
Contributor

Hi Team,

I wanted to let you know that I'm unable to continue working on this issue because I can't reproduce the problem; I cannot find any entries with multiple P373 values. Therefore, I'll be unassigning myself.

If anyone else is able to take a look, I would greatly appreciate it. Thank you for your understanding!

@zihanpan zihanpan removed their assignment Oct 20, 2024
@nicolas-raoul
Copy link
Member

@zihanpan Understood! If you wrote a SPARQL query to find such elements, would you mind posting it here? Thanks! 🙂

Otherwise, if anyone can write that query, that would be very helpful.

@Ainali
Copy link
Author

Ainali commented Oct 20, 2024

Otherwise, if anyone can write that query, that would be very helpful.

Here is a query with the top100 with most categories: https://qlever.cs.uni-freiburg.de/wikidata/FONilH?exec=true

@nicolas-raoul
Copy link
Member

@Ainali Thanks! Any query that would return a Wikidata element which has more than one P373 property? 🙂

@mnalis
Copy link
Contributor

mnalis commented Oct 21, 2024

@Ainali Thanks! Any query that would return a Wikidata element which has more than one P373 property? 🙂

Ummm, doesn't that query returns just that @nicolas-raoul?

e.g. first result is https://www.wikidata.org/wiki/Q2865059 which has dozens of P373 - Commons category: Arthur Constantin Krebs, Inventors from France, Births in Vesoul, Deaths in Quimperlé, Steam engine inventors ...

Or have I misunderstood what is being asked?

@mnalis
Copy link
Contributor

mnalis commented Oct 21, 2024

also, in 5.2.2. on quick glance it seems to be working; could someone confirm?

e.g. choosing Q2865059 as depicts does show me multiple categories from it (after several seconds of waiting for spinner to complete, of course):

small_Screenshot_20241021_053509_Commons small_Screenshot_20241021_053550_Commons

@nicolas-raoul
Copy link
Member

@Ainali Ah fantastic! Sorry I was on mobile and did not read carefully enough. 🙇

@chrisdebian
Copy link

Hi, all. Is this still an issue with the latest release?

Thanks,

Chris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants