Skip to content

Respect "Default description language" (currently default value is set to "bug" Basa Ugi) #6191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nicolas-raoul opened this issue Feb 17, 2025 · 4 comments · May be fixed by #6221
Open

Respect "Default description language" (currently default value is set to "bug" Basa Ugi) #6191

nicolas-raoul opened this issue Feb 17, 2025 · 4 comments · May be fixed by #6221
Assignees
@yuvraj-coder1
Labels
high priority nearby
Milestone
v5.4.0

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 17, 2025 •
edited
Loading

Issue #6123 was fixed by this change, which unfortunately has a problem: it overwrites the description language, so even if for instance your Default description language in the app's settings is set to Japanese, the description language will be bug by default (language bug is Basa Ugi language, it was chosen to ease debugging of the present issue.

The present task is to make the app respect the Default description language from the app's settings.

The easiest might be to:

  1. Do a git bisect, to identify from when issue Nearby upload not being linked from Wikidata #6123 existed.
  2. Either revert that commit or fix it. Knowing the commit will probably make it much easier to fix.
nicolas-raoul added a commit that referenced this issue Feb 17, 2025
@Sujal-Gupta-SG @nicolas-raoul
Fix #6188 (Nearby upload not being linked from Wikidata), though it i…
40241b4 
…ntroduces issue #6191

* Make neccesary changes

* Make neccesary changes

* spacing

---------

Co-authored-by: Nicolas Raoul <[email protected]>
@Sujal-Gupta-SG
Copy link
Contributor

i will work on this

@nicolas-raoul
Copy link
Member Author

@Sujal-Gupta-SG You have other tasks assigned, let's give others a chance to check this one. Thank you for your understanding. :-)

@yuvraj-coder1
Copy link
Contributor

hi can i do this.

@nicolas-raoul
Copy link
Member Author

Thanks @yuvraj-coder1 !
If anything is unclear, do not hesitate to ask.
I am looking forward to the result of the git bisect. :-)

nicolas-raoul added a commit that referenced this issue Feb 26, 2025
@Sujal-Gupta-SG @nicolas-raoul
Fix #6188 (Nearby upload not being linked from Wikidata), though it i…
2c800b9 
…ntroduces issue #6191

* Make neccesary changes

* Make neccesary changes

* spacing

---------

Co-authored-by: Nicolas Raoul <[email protected]>
@yuvraj-coder1 yuvraj-coder1 linked a pull request Feb 26, 2025 that will close this issue
Open
@RitikaPahwa4444 RitikaPahwa4444 added this to the v5.3.0 milestone Apr 6, 2025
@nicolas-raoul nicolas-raoul changed the title Respect "Default description language" (currently default value is set to "bug") Respect "Default description language" (currently default value is set to "bug" Basa Ugi) May 8, 2025
@nicolas-raoul nicolas-raoul mentioned this issue May 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuvraj-coder1 yuvraj-coder1

Labels
high priority nearby
Projects
None yet
Milestone
v5.4.0
4 participants
@nicolas-raoul @RitikaPahwa4444 @Sujal-Gupta-SG @yuvraj-coder1