Skip to content

[Bug]: The author, source, and uploaded info is missing from pages #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prototyperspective opened this issue Mar 31, 2025 · 8 comments · May be fixed by #6290
Open

[Bug]: The author, source, and uploaded info is missing from pages #6265

prototyperspective opened this issue Mar 31, 2025 · 8 comments · May be fixed by #6290

Comments

@prototyperspective
Copy link

Summary

On file pages there is the title, caption, description, license, coordinates, depictions, categories, uploaded date, a discussion page link, and file usages. However, there is not the key info on the source, the author(s), and the uploader.

Steps to reproduce

  1. Open the app
  2. Open a file

Expected behaviour

It should show the info on Author and Source that is in the File information template as well as the name of the Commons contributor who uploaded it with a link to that user's page.

Note that per CCBY, the author and/or source should be attributed, so it's basically violating that license.

Actual behaviour

None of that info is shown.

Device name

No response

Android version

Android 11

Commons app version

5.2.0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Prefer not

@nicolas-raoul
Copy link
Member

High priority: Add author, source, uploader (if they are not empty)

@PetitPotiron
Copy link

@nicolas-raoul
I would like to work on this one!

@nicolas-raoul
Copy link
Member

@PetitPotiron Fantastic, thanks a lot! If you have any question, feel free to ask here.

@RitikaPahwa4444 RitikaPahwa4444 added this to the v5.3.0 milestone Apr 6, 2025
@PetitPotiron
Copy link

PetitPotiron commented Apr 6, 2025

Hello again,
I will let someone else work on this because it is really too hard to understand the codebase for someone almost completely new to it... It is really complex and I can't work on it. I thought it would be quite easy but especially since I'm not very familiar with Android development, I can't do it, even if I read the app's docs. :(
Moreover, I don't have access to the Internet right now so it would be challenging to still try.

@nicolas-raoul
Copy link
Member

@PetitPotiron No worries, I know it is hard when starting from scratch and admire your motivation. Please do not hesitate to take on smaller tasks any time in the future. Thanks! :-)

@whym
Copy link
Collaborator

whym commented Apr 13, 2025

In what context do you want to see it? Should it be everywhere?

It looks like for now, files visited via a category will have the author information. (This is controlled using isCategoryImage of MediaDetailsFragment in the code.)
EDIT: actually, no. It looks like isCategoryImage seems always false. (Dead code?)

Everywhere except for the list of your own uploads might make sense. (There might be other exceptions I forget to include.)

@nicolas-raoul
Copy link
Member

Everywhere except for the list of your own uploads

Sounds good indeed! 👍

@ananas304
Copy link

Hi! I’d like to work on this issue. I’ve gone through the description and will start working on it right away. Let me know if there’s anything specific I should keep in mind while implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants