Skip to content

Commit 49a321e

Browse files
committed
Update based on review feedback
Ensure all changes are part of spec.md, and csi.proto is generated by "make". Mark new fields as alpha. Include a top-level note about quarantine states.
1 parent d6966c8 commit 49a321e

File tree

3 files changed

+274
-257
lines changed

3 files changed

+274
-257
lines changed

csi.proto

+6-5
Original file line numberDiff line numberDiff line change
@@ -773,8 +773,9 @@ message ControllerUnpublishVolumeRequest {
773773
// The SP MAY make the volume inaccessible even when this field is
774774
// false.
775775
// This is an OPTIONAL field.
776-
bool fence = 4;
776+
bool fence = 4 [(alpha_field) = true];
777777
}
778+
778779
message ControllerUnpublishVolumeResponse {
779780
// Intentionally empty.
780781
}
@@ -1057,7 +1058,7 @@ message ControllerServiceCapability {
10571058

10581059
// Indicates the SP supports ControllerUnpublishVolume.fence
10591060
// field.
1060-
UNPUBLISH_FENCE = 13;
1061+
UNPUBLISH_FENCE = 13 [(alpha_enum_value) = true];
10611062
}
10621063

10631064
Type type = 1;
@@ -1301,7 +1302,7 @@ message NodeUnstageVolumeRequest {
13011302
// CO MUST NOT set this field to true unless SP has the
13021303
// FORCE_UNPUBLISH node capability.
13031304
// This in an OPTIONAL field.
1304-
bool force = 3;
1305+
bool force = 3 [(alpha_field) = true];
13051306
}
13061307

13071308
message NodeUnstageVolumeResponse {
@@ -1392,7 +1393,7 @@ message NodeUnpublishVolumeRequest {
13921393
// CO MUST NOT set this field to true unless SP has the
13931394
// FORCE_UNPUBLISH node capability.
13941395
// This in an OPTIONAL field.
1395-
bool force = 3;
1396+
bool force = 3 [(alpha_field) = true];
13961397
}
13971398

13981399
message NodeUnpublishVolumeResponse {
@@ -1508,7 +1509,7 @@ message NodeServiceCapability {
15081509
// field. Also indicates that the node supports the
15091510
// NodeUnstageVolume.force field if it also has the
15101511
// STAGE_UNSTAGE_VOLUME capability.
1511-
FORCE_UNPUBLISH = 5;
1512+
FORCE_UNPUBLISH = 5 [(alpha_enum_value) = true];
15121513
}
15131514

15141515
Type type = 1;

0 commit comments

Comments
 (0)