Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 69d9704

Browse files
committedMay 3, 2021
spec: add optional secrets to NodeGetVolumeStatsRequest
For BlockVolume type of volumes, there are very little stats that can be gathered. The only reasonable metric on the Node that is available without knowing the contents of the BlockVolume, is the Total capacity. Different backend storage systems can thin-provision BlockVolumes. Initially the Used storage will be low, and growing over time. This is not detectable through standard Operating System APIs, but the backend storage system can provide more acurate Available/Used stats through expert APIs. In order to allow the Node to retrieve advanced stats from the backend storage system, the secrets that are used for staging the volume can be provided.
1 parent da58351 commit 69d9704

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed
 

‎csi.proto

+7
Original file line numberDiff line numberDiff line change
@@ -1395,6 +1395,13 @@ message NodeGetVolumeStatsRequest {
13951395
// system/filesystem, but, at a minimum, SP MUST accept a max path
13961396
// length of at least 128 bytes.
13971397
string staging_target_path = 3;
1398+
1399+
// Secrets that the plugin can use to request additional statistics
1400+
// from the backend storage system.
1401+
// This field is OPTIONAL. Refer to the `Secrets Requirements`
1402+
// section on how to use this field.
1403+
map<string, string> secrets = 4
1404+
[(csi_secret) = true, (alpha_field) = true];
13981405
}
13991406

14001407
message NodeGetVolumeStatsResponse {

‎spec.md

+7
Original file line numberDiff line numberDiff line change
@@ -2401,6 +2401,13 @@ message NodeGetVolumeStatsRequest {
24012401
// system/filesystem, but, at a minimum, SP MUST accept a max path
24022402
// length of at least 128 bytes.
24032403
string staging_target_path = 3;
2404+
2405+
// Secrets that the plugin can use to request additional statistics
2406+
// from the backend storage system.
2407+
// This field is OPTIONAL. Refer to the `Secrets Requirements`
2408+
// section on how to use this field.
2409+
map<string, string> secrets = 4
2410+
[(csi_secret) = true, (alpha_field) = true];
24042411
}
24052412
24062413
message NodeGetVolumeStatsResponse {

0 commit comments

Comments
 (0)
Please sign in to comment.