Skip to content

Commit 948e2ec

Browse files
author
James DeFelice
committed
address review feedback
1 parent 948e871 commit 948e2ec

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

spec.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -560,10 +560,14 @@ If the plugin is unable to complete the GetPluginCapabilities call successfully,
560560
#### `Probe`
561561

562562
A Plugin MUST implement this RPC call.
563-
The primary utility of the Probe RPC is deployment verification: this can be a one time or periodic check to ensure that a plugin instance is healthy and has all dependencies available.
564-
This information can be used, for example, to monitor the health of the plugin and redeploy the plugin (or take other automated measures) when it becomes unhealthy.
563+
The primary utility of the Probe RPC is to verify that the plugin is in a healthy state.
564+
If an unhealthy state is reported, via a non-success response, a CO MAY take action with the intent to bring the plugin to a healthy state.
565+
Such actions MAY include, but SHALL NOT be limited to, the following:
565566

566-
The Plugin SHOULD verify if it has the right configurations, devices, dependencies and drivers in order to run and return a success if the validation succeeds.
567+
* Restarting the plugin container, or
568+
* Notifying the plugin supervisor.
569+
570+
The Plugin MAY verify that it has the right configurations, devices, dependencies and drivers in order to run and return a success if the validation succeeds.
567571
The CO MAY invoke this RPC at any time after version negotiation has been completed (see `GetSupportedVersions`).
568572
A CO MAY invoke this call multiple times with the understanding that a plugin's implementation MAY NOT be trivial and there MAY be overhead incurred by such repeated calls.
569573
The SP SHALL document guidance and known limitations regarding a particular Plugin's implementation of this RPC.
@@ -1637,7 +1641,8 @@ Supervised plugins MAY be isolated and/or resource-bounded.
16371641
##### Available Services
16381642

16391643
* Plugin Packages MAY support all or a subset of CSI services; service combinations MAY be configurable at runtime by the Plugin Supervisor.
1640-
* A plugin must know the "mode" in which it's operating: mode of operation is NOT discoverable via interaction with the CO via the CSI specification.
1644+
* A plugin must know the "mode" in which it is operating (e.g. node, controller, or both).
1645+
* This specification does not dictate the mechanism by which mode of operation must be discovered, and instead places that burden upon the SP.
16411646
* Misconfigured plugin software SHOULD fail-fast with an OS-appropriate error code.
16421647

16431648
##### Linux Capabilities

0 commit comments

Comments
 (0)