Skip to content

Commit 9e3910d

Browse files
committed
Add source_volume_group_id to ListVolumeGroupSnapshotsRequest
1 parent ad31f6e commit 9e3910d

File tree

2 files changed

+24
-12
lines changed

2 files changed

+24
-12
lines changed

csi.proto

+12-6
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,14 @@ service Controller {
136136
option (alpha_method) = true;
137137
}
138138

139-
rpc GetVolumeGroup(GetVolumeGroupRequest)
140-
returns (GetVolumeGroupResponse) {
139+
rpc ControllerGetVolumeGroup(ControllerGetVolumeGroupRequest)
140+
returns (ControllerGetVolumeGroupResponse) {
141141
option (alpha_method) = true;
142142
}
143143

144-
rpc GetVolumeGroupSnapshot(GetVolumeGroupSnapshotRequest)
145-
returns (GetVolumeGroupSnapshotResponse) {
144+
rpc ControllerGetVolumeGroupSnapshot(
145+
ControllerGetVolumeGroupSnapshotRequest)
146+
returns (ControllerGetVolumeGroupSnapshotResponse) {
146147
option (alpha_method) = true;
147148
}
148149
}
@@ -1103,7 +1104,7 @@ message VolumeGroup {
11031104
// This field is REQUIRED.
11041105
// To support the creation of an empty group, this list can be empty.
11051106
// However, this field is not empty in the following cases:
1106-
// - Response from ListVolumeGroups or GetVolumeGroup if the
1107+
// - Response from ListVolumeGroups or ControllerGetVolumeGroup if the
11071108
// VolumeGroup is not empty.
11081109
// - Response from ModifyVolumeGroup if the VolumeGroup is not
11091110
// empty after modification.
@@ -1346,11 +1347,16 @@ message ListVolumeGroupSnapshotsRequest {
13461347
// An empty string is equal to an unspecified field value.
13471348
string starting_token = 2;
13481349

1350+
// Identity information for the source volume group.
1351+
// This field is OPTIONAL.
1352+
// It can be used to list group snapshots by volume group.
1353+
string source_volume_group_id = 3;
1354+
13491355
// Secrets required by plugin to complete ListVolumeGroupSnapshot
13501356
// request.
13511357
// This field is OPTIONAL. Refer to the `Secrets Requirements`
13521358
// section on how to use this field.
1353-
map<string, string> secrets = 3 [(csi_secret) = true];
1359+
map<string, string> secrets = 4 [(csi_secret) = true];
13541360
}
13551361

13561362
message ListVolumeGroupSnapshotsResponse {

spec.md

+12-6
Original file line numberDiff line numberDiff line change
@@ -417,13 +417,14 @@ service Controller {
417417
option (alpha_method) = true;
418418
}
419419
420-
rpc GetVolumeGroup(GetVolumeGroupRequest)
421-
returns (GetVolumeGroupResponse) {
420+
rpc ControllerGetVolumeGroup(ControllerGetVolumeGroupRequest)
421+
returns (ControllerGetVolumeGroupResponse) {
422422
option (alpha_method) = true;
423423
}
424424
425-
rpc GetVolumeGroupSnapshot(GetVolumeGroupSnapshotRequest)
426-
returns (GetVolumeGroupSnapshotResponse) {
425+
rpc ControllerGetVolumeGroupSnapshot(
426+
ControllerGetVolumeGroupSnapshotRequest)
427+
returns (ControllerGetVolumeGroupSnapshotResponse) {
427428
option (alpha_method) = true;
428429
}
429430
}
@@ -1780,7 +1781,7 @@ message VolumeGroup {
17801781
// This field is REQUIRED.
17811782
// To support the creation of an empty group, this list can be empty.
17821783
// However, this field is not empty in the following cases:
1783-
// - Response from ListVolumeGroups or GetVolumeGroup if the
1784+
// - Response from ListVolumeGroups or ControllerGetVolumeGroup if the
17841785
// VolumeGroup is not empty.
17851786
// - Response from ModifyVolumeGroup if the VolumeGroup is not
17861787
// empty after modification.
@@ -2181,11 +2182,16 @@ message ListVolumeGroupSnapshotsRequest {
21812182
// An empty string is equal to an unspecified field value.
21822183
string starting_token = 2;
21832184
2185+
// Identity information for the source volume group.
2186+
// This field is OPTIONAL.
2187+
// It can be used to list group snapshots by volume group.
2188+
string source_volume_group_id = 3;
2189+
21842190
// Secrets required by plugin to complete ListVolumeGroupSnapshot
21852191
// request.
21862192
// This field is OPTIONAL. Refer to the `Secrets Requirements`
21872193
// section on how to use this field.
2188-
map<string, string> secrets = 3 [(csi_secret) = true];
2194+
map<string, string> secrets = 4 [(csi_secret) = true];
21892195
}
21902196
21912197
message ListVolumeGroupSnapshotsResponse {

0 commit comments

Comments
 (0)