Skip to content

Commit c918b7f

Browse files
Modify wording based on comments on August 3rd
1 parent 3e57adf commit c918b7f

File tree

3 files changed

+26
-18
lines changed

3 files changed

+26
-18
lines changed

csi.proto

+11-6
Original file line numberDiff line numberDiff line change
@@ -383,10 +383,14 @@ message CreateVolumeRequest {
383383
// choose where the provisioned volume is accessible from.
384384
TopologyRequirement accessibility_requirements = 7;
385385

386-
// Plugin specific parameters to apply, passed in as opaque
387-
// key-value pairs. This field is OPTIONAL. The Plugin is
388-
// responsible for parsing and validating these parameters.
389-
// COs will treat these as opaque. Plugins MUST treat these
386+
// Plugin specific creation-time parameters passed in as opaque
387+
// key-value pairs. These mutable_parameteres MAY also be
388+
// changed during the lifetime of the volume via a subsequent
389+
// `ControllerModifyVolume` RPC. This field is OPTIONAL.
390+
// The Plugin is responsible for parsing and validating these
391+
// parameters. COs will treat these as opaque.
392+
393+
// Plugins MUST treat these
390394
// as if they take precedence over the parameters field.
391395
// This field SHALL NOT be specified unless the SP has the
392396
// MODIFY_VOLUME plugin capability.
@@ -1009,8 +1013,9 @@ message ControllerModifyVolumeRequest {
10091013
// section on how to use this field.
10101014
map<string, string> secrets = 2 [(csi_secret) = true];
10111015

1012-
// Plugin specific parameters to apply, passed in as opaque key-value
1013-
// pairs. This field is REQUIRED. The Plugin is responsible for
1016+
// Plugin specific volume attributes to mutate, passed in as
1017+
// opaque key-value pairs.
1018+
// This field is REQUIRED. The Plugin is responsible for
10141019
// parsing and validating these parameters. COs will treat these
10151020
// as opaque. The CO SHOULD specify the intended values of all mutable
10161021
// parameters it intends to modify. SPs MUST NOT modify volumes based

lib/go/csi/csi.pb.go

+4-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec.md

+11-6
Original file line numberDiff line numberDiff line change
@@ -854,10 +854,14 @@ message CreateVolumeRequest {
854854
// choose where the provisioned volume is accessible from.
855855
TopologyRequirement accessibility_requirements = 7;
856856
857-
// Plugin specific parameters to apply, passed in as opaque
858-
// key-value pairs. This field is OPTIONAL. The Plugin is
859-
// responsible for parsing and validating these parameters.
860-
// COs will treat these as opaque. Plugins MUST treat these
857+
// Plugin specific creation-time parameters passed in as opaque
858+
// key-value pairs. These mutable_parameteres MAY also be
859+
// changed during the lifetime of the volume via a subsequent
860+
// `ControllerModifyVolume` RPC. This field is OPTIONAL.
861+
// The Plugin is responsible for parsing and validating these
862+
// parameters. COs will treat these as opaque.
863+
864+
// Plugins MUST treat these
861865
// as if they take precedence over the parameters field.
862866
// This field SHALL NOT be specified unless the SP has the
863867
// MODIFY_VOLUME plugin capability.
@@ -1667,8 +1671,9 @@ message ControllerModifyVolumeRequest {
16671671
// section on how to use this field.
16681672
map<string, string> secrets = 2 [(csi_secret) = true];
16691673
1670-
// Plugin specific parameters to apply, passed in as opaque key-value
1671-
// pairs. This field is REQUIRED. The Plugin is responsible for
1674+
// Plugin specific volume attributes to mutate, passed in as
1675+
// opaque key-value pairs.
1676+
// This field is REQUIRED. The Plugin is responsible for
16721677
// parsing and validating these parameters. COs will treat these
16731678
// as opaque. The CO SHOULD specify the intended values of all mutable
16741679
// parameters it intends to modify. SPs MUST NOT modify volumes based

0 commit comments

Comments
 (0)