Skip to content

Commit d64255d

Browse files
committed
Change required capability for published_node_ids in GetVolume
Instead of PUBLISH_UNPUBLISH_VOLUME, use the LIST_VOLUMES_PUBLISHED_NODES capability to control the published_node_ids field in ControllerGetVolume. This change is to be more consistent with the existing behavior. It is a backwards-incompatible change, but the API is alpha. Also clarify the LIST_VOLUMES_PUBLISHED_NODES docs.
1 parent 486e6bd commit d64255d

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Diff for: csi.proto

+4-2
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ message ControllerGetVolumeResponse {
922922
// A list of all the `node_id` of nodes that this volume is
923923
// controller published on.
924924
// This field is OPTIONAL.
925-
// This field MUST be specified if the PUBLISH_UNPUBLISH_VOLUME
925+
// This field MUST be specified if the LIST_VOLUMES_PUBLISHED_NODES
926926
// controller capability is supported.
927927
// published_node_ids MAY include nodes not published to or
928928
// reported by the SP. The CO MUST be resilient to that.
@@ -1049,7 +1049,9 @@ message ControllerServiceCapability {
10491049
EXPAND_VOLUME = 9;
10501050

10511051
// Indicates the SP supports the
1052-
// ListVolumesResponse.entry.published_nodes field
1052+
// ListVolumesResponse.entry.published_node_ids field and the
1053+
// ControllerGetVolumeResponse.published_node_ids field.
1054+
// The SP MUST also support PUBLISH_UNPUBLISH_VOLUME.
10531055
LIST_VOLUMES_PUBLISHED_NODES = 10;
10541056

10551057
// Indicates that the Controller service can report volume

Diff for: spec.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -1553,7 +1553,7 @@ message ControllerGetVolumeResponse {
15531553
// A list of all the `node_id` of nodes that this volume is
15541554
// controller published on.
15551555
// This field is OPTIONAL.
1556-
// This field MUST be specified if the PUBLISH_UNPUBLISH_VOLUME
1556+
// This field MUST be specified if the LIST_VOLUMES_PUBLISHED_NODES
15571557
// controller capability is supported.
15581558
// published_node_ids MAY include nodes not published to or
15591559
// reported by the SP. The CO MUST be resilient to that.
@@ -1709,7 +1709,9 @@ message ControllerServiceCapability {
17091709
EXPAND_VOLUME = 9;
17101710
17111711
// Indicates the SP supports the
1712-
// ListVolumesResponse.entry.published_nodes field
1712+
// ListVolumesResponse.entry.published_node_ids field and the
1713+
// ControllerGetVolumeResponse.published_node_ids field.
1714+
// The SP MUST also support PUBLISH_UNPUBLISH_VOLUME.
17131715
LIST_VOLUMES_PUBLISHED_NODES = 10;
17141716
17151717
// Indicates that the Controller service can report volume

0 commit comments

Comments
 (0)