Skip to content

Commit f6b6d53

Browse files
authored
Move VolumeGroupSnapshot to GA (#573)
1 parent 2f34062 commit f6b6d53

File tree

3 files changed

+1182
-1243
lines changed

3 files changed

+1182
-1243
lines changed

csi.proto

+3-28
Original file line numberDiff line numberDiff line change
@@ -109,26 +109,21 @@ service Controller {
109109
}
110110

111111
service GroupController {
112-
option (alpha_service) = true;
113-
114112
rpc GroupControllerGetCapabilities (
115113
GroupControllerGetCapabilitiesRequest)
116114
returns (GroupControllerGetCapabilitiesResponse) {}
117115

118116
rpc CreateVolumeGroupSnapshot(CreateVolumeGroupSnapshotRequest)
119117
returns (CreateVolumeGroupSnapshotResponse) {
120-
option (alpha_method) = true;
121118
}
122119

123120
rpc DeleteVolumeGroupSnapshot(DeleteVolumeGroupSnapshotRequest)
124121
returns (DeleteVolumeGroupSnapshotResponse) {
125-
option (alpha_method) = true;
126122
}
127123

128124
rpc GetVolumeGroupSnapshot(
129125
GetVolumeGroupSnapshotRequest)
130126
returns (GetVolumeGroupSnapshotResponse) {
131-
option (alpha_method) = true;
132127
}
133128
}
134129

@@ -229,7 +224,7 @@ message PluginCapability {
229224
// attempt to invoke the REQUIRED GroupController service RPCs, as
230225
// well as specific RPCs as indicated by
231226
// GroupControllerGetCapabilities.
232-
GROUP_CONTROLLER_SERVICE = 3 [(alpha_enum_value) = true];
227+
GROUP_CONTROLLER_SERVICE = 3;
233228

234229
// SNAPSHOT_METADATA_SERVICE indicates that the Plugin provides
235230
// RPCs to retrieve metadata on the allocated blocks of a single
@@ -1287,7 +1282,7 @@ message Snapshot {
12871282
// and SP SHALL allow it to be deleted separately.
12881283
// If this message is inside a VolumeGroupSnapshot message, the value
12891284
// MUST be the same as the group_snapshot_id in that message.
1290-
string group_snapshot_id = 6 [(alpha_field) = true];
1285+
string group_snapshot_id = 6;
12911286
}
12921287
message DeleteSnapshotRequest {
12931288
// The ID of the snapshot to be deleted.
@@ -1760,32 +1755,25 @@ message NodeExpandVolumeResponse {
17601755
int64 capacity_bytes = 1;
17611756
}
17621757
message GroupControllerGetCapabilitiesRequest {
1763-
option (alpha_message) = true;
1764-
17651758
// Intentionally empty.
17661759
}
17671760

17681761
message GroupControllerGetCapabilitiesResponse {
1769-
option (alpha_message) = true;
1770-
17711762
// All the capabilities that the group controller service supports.
17721763
// This field is OPTIONAL.
17731764
repeated GroupControllerServiceCapability capabilities = 1;
17741765
}
17751766

17761767
// Specifies a capability of the group controller service.
17771768
message GroupControllerServiceCapability {
1778-
option (alpha_message) = true;
1779-
17801769
message RPC {
17811770
enum Type {
17821771
UNKNOWN = 0;
17831772

17841773
// Indicates that the group controller plugin supports
17851774
// creating, deleting, and getting details of a volume
17861775
// group snapshot.
1787-
CREATE_DELETE_GET_VOLUME_GROUP_SNAPSHOT = 1
1788-
[(alpha_enum_value) = true];
1776+
CREATE_DELETE_GET_VOLUME_GROUP_SNAPSHOT = 1;
17891777
}
17901778

17911779
Type type = 1;
@@ -1797,8 +1785,6 @@ message GroupControllerServiceCapability {
17971785
}
17981786
}
17991787
message CreateVolumeGroupSnapshotRequest {
1800-
option (alpha_message) = true;
1801-
18021788
// The suggested name for the group snapshot. This field is REQUIRED
18031789
// for idempotency.
18041790
// Any Unicode string that conforms to the length limit is allowed
@@ -1826,16 +1812,12 @@ message CreateVolumeGroupSnapshotRequest {
18261812
}
18271813

18281814
message CreateVolumeGroupSnapshotResponse {
1829-
option (alpha_message) = true;
1830-
18311815
// Contains all attributes of the newly created group snapshot.
18321816
// This field is REQUIRED.
18331817
VolumeGroupSnapshot group_snapshot = 1;
18341818
}
18351819

18361820
message VolumeGroupSnapshot {
1837-
option (alpha_message) = true;
1838-
18391821
// The identifier for this group snapshot, generated by the plugin.
18401822
// This field MUST contain enough information to uniquely identify
18411823
// this specific snapshot vs all other group snapshots supported by
@@ -1867,8 +1849,6 @@ message VolumeGroupSnapshot {
18671849
bool ready_to_use = 4;
18681850
}
18691851
message DeleteVolumeGroupSnapshotRequest {
1870-
option (alpha_message) = true;
1871-
18721852
// The ID of the group snapshot to be deleted.
18731853
// This field is REQUIRED.
18741854
string group_snapshot_id = 1;
@@ -1895,11 +1875,8 @@ message DeleteVolumeGroupSnapshotRequest {
18951875

18961876
message DeleteVolumeGroupSnapshotResponse {
18971877
// Intentionally empty.
1898-
option (alpha_message) = true;
18991878
}
19001879
message GetVolumeGroupSnapshotRequest {
1901-
option (alpha_message) = true;
1902-
19031880
// The ID of the group snapshot to fetch current group snapshot
19041881
// information for.
19051882
// This field is REQUIRED.
@@ -1926,8 +1903,6 @@ message GetVolumeGroupSnapshotRequest {
19261903
}
19271904

19281905
message GetVolumeGroupSnapshotResponse {
1929-
option (alpha_message) = true;
1930-
19311906
// This field is REQUIRED
19321907
VolumeGroupSnapshot group_snapshot = 1;
19331908
}

0 commit comments

Comments
 (0)