Skip to content

NodePublishVolume should not require multi-node capability if called on the same node with different target_paths #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgcostea opened this issue Jan 28, 2019 · 2 comments

Comments

@rgcostea
Copy link

Per the spec, the NodePublishVolume RPC

MAY be called by the CO multiple times on the same node for the same volume with possibly different target_path and/or other arguments if the volume has MULTI_NODE capability (i.e., access_mode is either MULTI_NODE_READER_ONLY, MULTI_NODE_SINGLE_WRITER or MULTI_NODE_MULTI_WRITER).

But if a plugin cannot present the same volume on different nodes simultaneously (block storage) it must report as not supporting multi-node, because supporting multiple containers on the same node is not multi-node.

However, we do support mounting the same volume on the same node at different target_paths (to different containers). I would like to request a capability to say that a volume can be published to multiple containers on the same node. Perhaps we can add a new access mode named SINGLE_NODE_MULTI_ACCESS? Then the spec could be updated to indicate that the NodePublishVolume RPC could work when the volume has this capability.

@jieyu
Copy link
Member

jieyu commented Feb 6, 2019

xref #150

@rgcostea you can find some relevant discussion there.

I do believe there's need to introduce some access mode indicating if a volume can be published multiple times on a node or not. Depending on CO's implementation, some CO might prefer doing node publish just once, and use bind mounts for workloads. Some CO might decide to do call node publish multiple times, one for each workload.

I think the current status-quo is that all CO simply assumes that a volume can be published multiple times on a node for SINGLE_NODE capability volumes.

@bswartz
Copy link
Contributor

bswartz commented Feb 22, 2019

@jieyu What you wrote above directly contradicts what the spec says (thanks to the language added in #150) Either the COs are violating the spec and we should change the COs, or else we need to reverse #150.

@saad-ali saad-ali added this to the v1.2 milestone Mar 6, 2019
@jdef jdef modified the milestones: v1.2, v1.3 Feb 24, 2020
@saad-ali saad-ali removed this from the v1.3 milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants