Skip to content

Commit 546e476

Browse files
authored
Merge pull request #4112 from apostasie/bump-deps
Bump CNI to 1.3 (and minor tooling versions)
2 parents 2aad180 + 1bd12e8 commit 546e476

File tree

6 files changed

+24
-33
lines changed

6 files changed

+24
-33
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ ARG BUILDG_VERSION=v0.4.1@BINARY
4545
ARG GO_VERSION=1.24
4646
ARG UBUNTU_VERSION=24.04
4747
ARG CONTAINERIZED_SYSTEMD_VERSION=v0.1.1
48-
ARG GOTESTSUM_VERSION=v1.12.0
48+
ARG GOTESTSUM_VERSION=v1.12.1
4949
ARG NYDUS_VERSION=v2.3.0
50-
ARG SOCI_SNAPSHOTTER_VERSION=0.8.0
50+
ARG SOCI_SNAPSHOTTER_VERSION=0.9.0
5151
ARG KUBO_VERSION=v0.33.2
5252

5353
FROM --platform=$BUILDPLATFORM tonistiigi/xx:1.6.1@sha256:923441d7c25f1e2eb5789f82d987693c47b8ed987c4ab3b075d6ed2b5d6779a3 AS xx

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ require (
2525
github.com/containerd/stargz-snapshotter/estargz v0.16.3
2626
github.com/containerd/stargz-snapshotter/ipfs v0.16.3
2727
github.com/containerd/typeurl/v2 v2.2.3
28-
github.com/containernetworking/cni v1.2.3
28+
github.com/containernetworking/cni v1.3.0
2929
github.com/containernetworking/plugins v1.6.2
3030
github.com/coreos/go-iptables v0.8.0
3131
github.com/coreos/go-systemd/v22 v22.5.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ github.com/containerd/ttrpc v1.2.7 h1:qIrroQvuOL9HQ1X6KHe2ohc7p+HP/0VE6XPU7elJRq
6565
github.com/containerd/ttrpc v1.2.7/go.mod h1:YCXHsb32f+Sq5/72xHubdiJRQY9inL4a4ZQrAbN1q9o=
6666
github.com/containerd/typeurl/v2 v2.2.3 h1:yNA/94zxWdvYACdYO8zofhrTVuQY73fFU1y++dYSw40=
6767
github.com/containerd/typeurl/v2 v2.2.3/go.mod h1:95ljDnPfD3bAbDJRugOiShd/DlAAsxGtUBhJxIn7SCk=
68-
github.com/containernetworking/cni v1.2.3 h1:hhOcjNVUQTnzdRJ6alC5XF+wd9mfGIUaj8FuJbEslXM=
69-
github.com/containernetworking/cni v1.2.3/go.mod h1:DuLgF+aPd3DzcTQTtp/Nvl1Kim23oFKdm2okJzBQA5M=
68+
github.com/containernetworking/cni v1.3.0 h1:v6EpN8RznAZj9765HhXQrtXgX+ECGebEYEmnuFjskwo=
69+
github.com/containernetworking/cni v1.3.0/go.mod h1:Bs8glZjjFfGPHMw6hQu82RUgEPNGEaBb9KS5KtNMnJ4=
7070
github.com/containernetworking/plugins v1.6.2 h1:pqP8Mq923TLyef5g97XfJ/xpDeVek4yF8A4mzy9Tc4U=
7171
github.com/containernetworking/plugins v1.6.2/go.mod h1:SP5UG3jDO9LtmfbBJdP+nl3A1atOtbj2MBOYsnaxy64=
7272
github.com/containers/ocicrypt v1.2.1 h1:0qIOTT9DoYwcKmxSt8QJt+VzMY18onl9jUXsxpVhSmM=

hack/configure-windows-ci.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ echo "configuration complete! Printing configuration..."
1818
echo "Service:"
1919
get-service containerd
2020
echo "cni configuration"
21-
cat "$Env:ProgramFiles\containerd\cni\conf\0-containerd-nat.conf"
21+
cat "$Env:ProgramFiles\containerd\cni\conf\0-containerd-nat.conflist"
2222
ls "$Env:ProgramFiles\containerd\cni\bin"
2323
echo "containerd install"
2424
ls "$Env:ProgramFiles\containerd\"

hack/provisioning/windows/cni.sh

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,23 +81,27 @@ subnet="$(calculate_subnet "$GATEWAY" "$PREFIX_LEN")"
8181
# https://github.com/microsoft/windows-container-networking/pull/45),
8282
# so it must match a network type in:
8383
# https://docs.microsoft.com/en-us/windows-server/networking/technologies/hcn/hcn-json-document-schemas
84-
bash -c 'cat >"'"${CNI_CONFIG_DIR}"'"/0-containerd-nat.conf <<EOF
84+
bash -c 'cat >"'"${CNI_CONFIG_DIR}"'"/0-containerd-nat.conflist <<EOF
8585
{
86-
"cniVersion": "1.0.0",
87-
"name": "nat",
88-
"type": "nat",
89-
"master": "Ethernet",
90-
"ipam": {
86+
"cniVersion": "1.0.0",
87+
"name": "nat",
88+
"plugins": [
89+
{
90+
"type": "nat",
91+
"master": "Ethernet",
92+
"ipam": {
9193
"subnet": "'"$subnet"'",
9294
"routes": [
93-
{
94-
"GW": "'"$GATEWAY"'"
95-
}
95+
{
96+
"GW": "'"$GATEWAY"'"
97+
}
9698
]
97-
},
98-
"capabilities": {
99+
},
100+
"capabilities": {
99101
"portMappings": true,
100102
"dns": true
103+
}
101104
}
105+
]
102106
}
103107
EOF'

pkg/netutil/netutil.go

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import (
2828
"path/filepath"
2929
"sort"
3030
"strconv"
31-
"strings"
3231

3332
"github.com/containernetworking/cni/libcni"
3433

@@ -533,21 +532,9 @@ func cniLoad(fileNames []string) (configList []*NetworkConfig, err error) {
533532
}
534533

535534
var netConfigList *libcni.NetworkConfigList
536-
if strings.HasSuffix(fileName, ".conflist") {
537-
netConfigList, err = libcni.ConfListFromBytes(bytes)
538-
if err != nil {
539-
return nil, wrapCNIError(fileName, err)
540-
}
541-
} else {
542-
var netConfig *libcni.NetworkConfig
543-
netConfig, err = libcni.ConfFromBytes(bytes)
544-
if err != nil {
545-
return nil, wrapCNIError(fileName, err)
546-
}
547-
netConfigList, err = libcni.ConfListFromConf(netConfig)
548-
if err != nil {
549-
return nil, wrapCNIError(fileName, err)
550-
}
535+
netConfigList, err = libcni.NetworkConfFromBytes(bytes)
536+
if err != nil {
537+
return nil, wrapCNIError(fileName, err)
551538
}
552539
id, nerdctlLabels := nerdctlIDLabels(netConfigList.Bytes)
553540
configList = append(configList, &NetworkConfig{

0 commit comments

Comments
 (0)