fix: test nerdctl ps filter

Signed-off-by: Shubharanshu Mahapatra <[email protected]>

Author: Shubhranshu153

cmd/nerdctl/container/container_list_linux_test.go

@@ -26,6 +26,7 @@ import (
 
 	"gotest.tools/v3/assert"
 
+	"github.com/containerd/nerdctl/mod/tigron/test"
 	"github.com/containerd/nerdctl/v2/pkg/formatter"
 	"github.com/containerd/nerdctl/v2/pkg/strutil"
 	"github.com/containerd/nerdctl/v2/pkg/tabutil"
@@ -628,3 +629,35 @@ func TestContainerListCheckCreatedTime(t *testing.T) {
 		t.Errorf("expected containers in decending order")
 	}
 }
+
+func TestContainerListStatusFilter(t *testing.T) {
+	testCase := nerdtest.Setup()
+	testCase.Setup = func(data test.Data, helpers test.Helpers) {
+		helpers.Ensure("create", "--name", data.Identifier("container"), testutil.CommonImage, "echo", "foo")
+		data.Labels().Set("cID", data.Identifier("container"))
+	}
+	testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
+		helpers.Anyhow("rm", "-f", data.Identifier("container"))
+	}
+
+	testCase.SubTests = []*test.Case{
+		// TODO: Refactor other filter tests
+		{
+			Description: "ps filter with status=created",
+			NoParallel:  true,
+			Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
+				return helpers.Command("ps", "-a", "--filter", "status=created", "--filter", fmt.Sprintf("name=%s", data.Labels().Get("cID")))
+			},
+			Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
+				return &test.Expected{
+					ExitCode: 0,
+					Output: func(stdout, info string, t *testing.T) {
+						assert.Assert(t, strings.Contains(stdout, data.Labels().Get("cID")), "No container found with status created")
+					},
+				}
+			},
+		},
+	}
+
+	testCase.Run(t)
+}

pkg/cmd/container/list.go

@@ -64,7 +64,6 @@ func filterContainers(ctx context.Context, client *containerd.Client, filters []
 		return nil, nil, err
 	}
 	containers = filterCtx.MatchesFilters(ctx)
-
 	sort.Slice(containers, func(i, j int) bool {
 		infoI, _ := containers[i].Info(ctx, containerd.WithoutRefreshedMetadata)
 		infoJ, _ := containers[j].Info(ctx, containerd.WithoutRefreshedMetadata)

pkg/cmd/container/list_util.go

@@ -25,6 +25,7 @@ import (
 
 	containerd "github.com/containerd/containerd/v2/client"
 	"github.com/containerd/containerd/v2/core/containers"
+	"github.com/containerd/errdefs"
 	"github.com/containerd/log"
 
 	"github.com/containerd/nerdctl/v2/pkg/containerutil"
@@ -235,6 +236,9 @@ func (cl *containerFilterContext) matchesTaskFilters(ctx context.Context, contai
 	defer cancel()
 	task, err := container.Task(ctx, nil)
 	if err != nil {
+		if errdefs.IsNotFound(err) {
+			return true
+		}
 		log.G(ctx).Warn(err)
 		return false
 	}