Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker daemon ipv6 support #182

Closed
fahedouch opened this issue Apr 22, 2021 · 3 comments · Fixed by #185
Closed

docker daemon ipv6 support #182

fahedouch opened this issue Apr 22, 2021 · 3 comments · Fixed by #185

Comments

@fahedouch
Copy link
Member

fahedouch commented Apr 22, 2021 •
edited
Loading

hello,

GA seems to supports ipv6 in docker daemon. before merging this PR #127

we should fix TestContainerInspectContainsPortConfig test by adding a condition on the binary or skipping it
@AkihiroSuda
Copy link
Member

Unrelated to this repo?

@fahedouch
Copy link
Member Author

in the CI i got this

=== RUN   TestContainerInspectContainsPortConfig
    container_inspect_test.go:39: assertion failed: {"80/tcp":[{"HostIp":"0.0.0.0","HostPort":"8080"}]} (expected string) != {"80/tcp":[{"HostIp":"0.0.0.0","HostPort":"8080"},{"HostIp":"::","HostPort":"8080"}]} (string)

I think we should skip this test until merging this PR #127

@fahedouch fahedouch mentioned this issue Apr 22, 2021
Closed
@AkihiroSuda AkihiroSuda mentioned this issue Apr 23, 2021
Merged
@AkihiroSuda
Copy link
Member

#185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TestContainerInspectContainsPortConfig: support Docker 20.10.6 AkihiroSuda/nerdctl
2 participants
@AkihiroSuda @fahedouch