Skip to content

Commit 8a77ffd

Browse files
Fixed test cases
1 parent 40ce51a commit 8a77ffd

File tree

3 files changed

+20
-19
lines changed

3 files changed

+20
-19
lines changed

.talismanrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,6 @@ fileignoreconfig:
88
checksum: 5baabd7d2c391648163f9371f0e5e9484f8fb90fa2284cfc378732ec3192c193
99
- filename: test/sanity-check/api/stack-test.js
1010
checksum: 198d5cf7ead33b079249dc3ecdee61a9c57453e93f1073ed0341400983e5aa53
11+
- filename: lib/stack/index.js
12+
checksum: 6aab5edf85efb17951418b4dc4402889cd24c8d786c671185074aeb4d50f0242
1113
version: ""

lib/stack/globalField/index.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@ import { createReadStream } from 'fs'
1010
*/
1111

1212
export function GlobalField (http, data = {}) {
13-
this.stackHeaders = data.stackHeaders
14-
if (data.apiVersion) {
15-
this.stackHeaders.api_version = data.apiVersion
16-
}
17-
if (data.branch) {
18-
this.stackHeaders.branch = data.branch
13+
const rawHeaders = data.stackHeaders || {}
14+
15+
this.stackHeaders = {
16+
...cloneDeep(rawHeaders),
17+
...(data.apiVersion ? { api_version: data.apiVersion } : {}),
18+
...(data.branch ? { branch: data.branch } : {})
1919
}
20+
2021
this.urlPath = `/global_fields`
2122

2223
if (data.global_field && data.global_field.uid) {

test/unit/globalField-test.js

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('Contentstack GlobalField test', () => {
1010
it('GlobalField test without uid', (done) => {
1111
const globalField = makeGlobalField()
1212
expect(globalField.urlPath).to.be.equal('/global_fields')
13-
expect(globalField.stackHeaders).to.be.equal(undefined)
13+
expect(globalField.stackHeaders).to.deep.equal({})
1414
expect(globalField.update).to.be.equal(undefined)
1515
expect(globalField.delete).to.be.equal(undefined)
1616
expect(globalField.fetch).to.be.equal(undefined)
@@ -25,10 +25,9 @@ describe('Contentstack GlobalField test', () => {
2525
...systemUidMock
2626
}
2727
})
28-
expect(globalField.urlPath).to.be.equal(
29-
`/global_fields/${systemUidMock.uid}`
30-
)
31-
expect(globalField.stackHeaders).to.be.equal(undefined)
28+
29+
expect(globalField.urlPath).to.be.equal(`/global_fields/${systemUidMock.uid}`)
30+
expect(globalField.stackHeaders).to.deep.equal({})
3231
expect(globalField.update).to.not.equal(undefined)
3332
expect(globalField.delete).to.not.equal(undefined)
3433
expect(globalField.fetch).to.not.equal(undefined)
@@ -218,10 +217,11 @@ describe('Contentstack GlobalField test', () => {
218217
describe('Contentstack GlobalField test (API Version 3.2)', () => {
219218
it('GlobalField test without uid', (done) => {
220219
const globalField = makeGlobalField({
221-
stackHeaders: stackHeadersMock,
222-
api_version: '3.2' })
223-
expect(globalField.urlPath).to.be.equal('/global_fields')
224-
expect(globalField.stackHeaders.api_version).to.be.equal('3.2')
220+
stackHeaders: { api_key: 'api_key', api_version: '3.2' }
221+
})
222+
223+
expect(globalField.urlPath).to.equal('/global_fields')
224+
expect(globalField.stackHeaders.api_version).to.equal('3.2')
225225
expect(globalField.stackHeaders).to.deep.equal({ api_key: 'api_key', api_version: '3.2' })
226226
done()
227227
})
@@ -231,8 +231,7 @@ describe('Contentstack GlobalField test (API Version 3.2)', () => {
231231
global_field: {
232232
...systemUidMock
233233
},
234-
stackHeaders: stackHeadersMock,
235-
api_version: '3.2'
234+
stackHeaders: { api_key: 'api_key', api_version: '3.2' }
236235
})
237236
expect(globalField.urlPath).to.be.equal(
238237
`/global_fields/${systemUidMock.uid}`
@@ -251,8 +250,7 @@ describe('Contentstack GlobalField test (API Version 3.2)', () => {
251250
global_field: {
252251
...systemUidMock
253252
},
254-
stackHeaders: stackHeadersMock,
255-
api_version: '3.2'
253+
stackHeaders: { api_key: 'api_key', api_version: '3.2' }
256254
})
257255
expect(globalField.urlPath).to.be.equal(
258256
`/global_fields/${systemUidMock.uid}`

0 commit comments

Comments
 (0)