shell: backend: telnet: Don't assert if connection closed

The code in shell_ops.c that calls telnet_write will assert if it
returns non-zero. For a telnet shell it's normal that the
network might disconnect unexepectedly, so that should not
trigger an assert.

Fixes #67637

(cherry picked from commit 3399e06)

Original-Link: zephyrproject-rtos/zephyr#67637
Original-Signed-off-by: Kevin ORourke <[email protected]>
GitOrigin-RevId: 3399e06
Cr-Build-Id: 8734380568354140561
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8734380568354140561
Copybot-Job-Name: zephyr-main-copybot-downstream
Change-Id: I4f40ac58f0ee844e4dff85196727fd3b4f56939d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5925541
Commit-Queue: Jeremy Bettis <[email protected]>
Tested-by: ChromeOS Prod (Robot) <[email protected]>
Tested-by: Jeremy Bettis <[email protected]>
Reviewed-by: Jeremy Bettis <[email protected]>

Author: kevinior

subsys/shell/backends/shell_telnet.c

@@ -708,7 +708,12 @@ static int telnet_write(const struct shell_transport *transport,
 			err = telnet_send(true);
 			if (err != 0) {
 				*cnt = length;
-				return err;
+				if ((err == -ENOTCONN) || (err == -ENETDOWN)) {
+					LOG_ERR("Network disconnected, shutting down");
+				} else {
+					LOG_ERR("Error %d, shutting down", err);
+				}
+				return 0; /* Return 0 to not trigger ASSERT in shell_ops.c */
 			}
 		}