Skip to content

login1 command wrappers do not return the call error #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
coderanger opened this issue Nov 26, 2019 · 1 comment
Open

login1 command wrappers do not return the call error #326

coderanger opened this issue Nov 26, 2019 · 1 comment
Labels
kind/breaking-api

Comments

@coderanger
Copy link

The pattern used in other packages here is something like return c.object.Call(...).Err but the wrapper methods in login1 just swallow any errors.
@lucab
Copy link
Contributor

lucab commented Dec 10, 2019

Thanks for the report.
I agree it would be better to align all those methods to return proper error value. If you are interested in doing it, I'll gladly review and merge a PR doing that.

@lucab lucab mentioned this issue Dec 10, 2019
Closed
@invidian invidian mentioned this issue Jan 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/breaking-api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucab @coderanger