Skip to content

Commit aac909d

Browse files
committed
wip(card-list): remove SharedSortableService & directive. Whew!
1 parent d69d68b commit aac909d

File tree

5 files changed

+11
-266
lines changed

5 files changed

+11
-266
lines changed

packages/angular-skyhook-card-list/public-api.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,3 @@ export * from "./src/spillTarget";
77

88
export { SkyhookCardListModule } from "./src/module";
99

10-
export { SharedSortableService } from "./src/SharedSortableService";

packages/angular-skyhook-card-list/src/SharedSortableService.ts

Lines changed: 0 additions & 197 deletions
This file was deleted.
Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,22 @@
1-
import { NgModule, ModuleWithProviders } from "@angular/core";
1+
import { NgModule } from "@angular/core";
22
import { CardListDirective } from "./card-list.directive";
33
import { CardListComponent } from "./card-list.component";
44
import { CardTemplateDirective } from "./card-template.directive";
55
import { CardRendererDirective } from "./card-renderer.directive";
66
import { CommonModule } from "@angular/common";
77
import { SkyhookDndModule } from "angular-skyhook";
8-
import { SharedSortableService } from "./SharedSortableService";
9-
import { SharedDirective } from "./shared.directive";
8+
9+
const EXPORTS = [
10+
CardListComponent,
11+
CardListDirective,
12+
CardTemplateDirective,
13+
CardRendererDirective,
14+
];
1015

1116
@NgModule({
12-
declarations: [
13-
CardListComponent,
14-
CardListDirective,
15-
CardTemplateDirective,
16-
CardRendererDirective,
17-
SharedDirective
18-
],
19-
exports: [
20-
CardListComponent,
21-
CardListDirective,
22-
CardTemplateDirective,
23-
CardRendererDirective,
24-
SharedDirective
25-
],
17+
declarations: EXPORTS,
18+
exports: EXPORTS,
2619
imports: [CommonModule, SkyhookDndModule]
2720
})
2821
export class SkyhookCardListModule {
29-
static forRoot(): ModuleWithProviders {
30-
return {
31-
ngModule: SkyhookCardListModule,
32-
providers: [
33-
SharedSortableService
34-
]
35-
}
36-
}
3722
}

packages/angular-skyhook-card-list/src/shared.directive.ts

Lines changed: 0 additions & 42 deletions
This file was deleted.

packages/examples/src/app/sortable/simple/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { ContainerComponent } from "./container.component";
2020
UtilityModule,
2121
SkyhookDndModule,
2222
SkyhookMultiBackendModule,
23-
SkyhookCardListModule.forRoot(),
23+
SkyhookCardListModule,
2424
RouterModule.forChild([
2525
{ path: "", component: ContainerComponent }
2626
])

0 commit comments

Comments
 (0)