Fix some lint warnings in tests

Signed-off-by: Bryan Boreham <[email protected]>

Author: bboreham

pkg/ring/lifecycler_test.go

@@ -340,7 +340,6 @@ func TestCheckReady(t *testing.T) {
 }
 
 type noopFlushTransferer struct {
-	lifecycler *Lifecycler
 }
 
 func (f *noopFlushTransferer) StopIncomingRequests()                 {}

pkg/ruler/rules/store_test.go

@@ -33,7 +33,7 @@ func Test_ConfigRuleStoreError(t *testing.T) {
 	}
 
 	store := NewConfigRuleStore(mock)
-	_, err := store.ListAllRuleGroups(nil)
+	_, err := store.ListAllRuleGroups(context.Background())
 
 	assert.Equal(t, mock.err, err, "Unexpected error returned")
 }
@@ -52,7 +52,7 @@ func Test_ConfigRuleStoreReturn(t *testing.T) {
 	}
 
 	store := NewConfigRuleStore(mock)
-	rules, _ := store.ListAllRuleGroups(nil)
+	rules, _ := store.ListAllRuleGroups(context.Background())
 
 	assert.Equal(t, 1, len(rules["user"]))
 	assert.Equal(t, id, store.since)
@@ -71,15 +71,15 @@ func Test_ConfigRuleStoreDelete(t *testing.T) {
 	}
 
 	store := NewConfigRuleStore(mock)
-	store.ListAllRuleGroups(nil)
+	_, _ = store.ListAllRuleGroups(context.Background())
 
 	mock.cfgs["user"] = configs.VersionedRulesConfig{
 		ID:        1,
 		Config:    configs.RulesConfig{},
 		DeletedAt: time.Unix(0, 1),
 	}
 
-	rules, _ := store.ListAllRuleGroups(nil)
+	rules, _ := store.ListAllRuleGroups(context.Background())
 
 	assert.Equal(t, 0, len(rules["user"]))
 }
@@ -97,7 +97,7 @@ func Test_ConfigRuleStoreAppend(t *testing.T) {
 	}
 
 	store := NewConfigRuleStore(mock)
-	store.ListAllRuleGroups(nil)
+	_, _ = store.ListAllRuleGroups(context.Background())
 
 	delete(mock.cfgs, "user")
 	mock.cfgs["user2"] = configs.VersionedRulesConfig{
@@ -106,7 +106,7 @@ func Test_ConfigRuleStoreAppend(t *testing.T) {
 		DeletedAt: zeroTime,
 	}
 
-	rules, _ := store.ListAllRuleGroups(nil)
+	rules, _ := store.ListAllRuleGroups(context.Background())
 
 	assert.Equal(t, 2, len(rules))
 }
@@ -134,7 +134,7 @@ func Test_ConfigRuleStoreSinceSet(t *testing.T) {
 	}
 
 	store := NewConfigRuleStore(mock)
-	store.ListAllRuleGroups(nil)
+	_, _ = store.ListAllRuleGroups(context.Background())
 	assert.Equal(t, configs.ID(100), store.since)
 
 	delete(mock.cfgs, "user")
@@ -145,7 +145,7 @@ func Test_ConfigRuleStoreSinceSet(t *testing.T) {
 		DeletedAt: zeroTime,
 	}
 
-	store.ListAllRuleGroups(nil)
+	_, _ = store.ListAllRuleGroups(context.Background())
 	assert.Equal(t, configs.ID(100), store.since)
 
 	mock.cfgs["user2"] = configs.VersionedRulesConfig{
@@ -154,7 +154,7 @@ func Test_ConfigRuleStoreSinceSet(t *testing.T) {
 		DeletedAt: zeroTime,
 	}
 
-	store.ListAllRuleGroups(nil)
+	_, _ = store.ListAllRuleGroups(context.Background())
 	assert.Equal(t, configs.ID(101), store.since)
 }