Skip to content

Commit 68c057e

Browse files
committed
fix: Support attributes using builtin type names
Fixes openapi-generators#359
1 parent 17daa73 commit 68c057e

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

openapi_python_client/utils.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import builtins
12
import re
23
from keyword import iskeyword
34

@@ -15,7 +16,7 @@ def fix_keywords(value: str) -> str:
1516
return value
1617

1718

18-
RESERVED_WORDS = ("self",)
19+
RESERVED_WORDS = set(dir(builtins)).union({"self"})
1920

2021

2122
def fix_reserved_words(value: str) -> str:

tests/test_utils.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,11 @@ def test__fix_keywords():
3838
assert utils.fix_keywords("None") == "None_"
3939

4040

41-
def test__fix_reserved_words():
42-
assert utils.fix_reserved_words("self") == "self_"
41+
@pytest.mark.parametrize(
42+
"reserved_word, expected", [("self", "self_"), ("int", "int_"), ("dict", "dict_"), ("not_reserved", "not_reserved")]
43+
)
44+
def test__fix_reserved_words(reserved_word: str, expected: str):
45+
assert utils.fix_reserved_words(reserved_word) == expected
4346

4447

4548
def test_to_valid_python_identifier():

0 commit comments

Comments
 (0)