Skip to content

P1223 find_last #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jensmaurer opened this issue Jan 26, 2019 · 16 comments · Fixed by cplusplus/draft#5642
Closed

P1223 find_last #149

jensmaurer opened this issue Jan 26, 2019 · 16 comments · Fixed by cplusplus/draft#5642
Labels
C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone
2022-telecon

Comments

@jensmaurer
Copy link
Member

P1223R1 find_backward (Zach Laine)
@jensmaurer jensmaurer added this to the 2019-02 milestone Jan 26, 2019
@jensmaurer jensmaurer added the LEWG Library Evolution label Jan 26, 2019
@tituswinters
Copy link

tituswinters commented Feb 23, 2019 •
edited by jensmaurer
Loading

LEWG in Kona:
Add find_last which allows ForwardIterator (and an overload with Sentinel for the last), drop find_backward, forward to LWG for C++20.
SF F N A SA
5 3 5 2 1

@tituswinters tituswinters added LWG Library and removed LEWG Library Evolution labels Feb 23, 2019
@jensmaurer jensmaurer removed this from the 2019-02 milestone Mar 21, 2019
@wg21bot
Copy link
Collaborator

wg21bot commented Jun 23, 2019

P1223R2 find_backward (Zach Laine)

@wg21bot wg21bot added this to the 2019-07 milestone Jun 23, 2019
@mclow mclow added the C++20 Targeted at C++20 label Jul 8, 2019
@mclow
Copy link

mclow commented Jul 16, 2019

Discussed in small group on Tuesday in Cologne

@jensmaurer jensmaurer modified the milestones: 2019-07, 2019-11 Aug 23, 2019
@mclow mclow removed the C++20 Targeted at C++20 label Nov 3, 2019
@mclow
Copy link

mclow commented Nov 3, 2019

This was not adopted for C++20. Removing the "C++20" label.

@JeffGarland JeffGarland added the C++23 Targeted at C++23 label Feb 18, 2020
@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@jensmaurer jensmaurer added IS Ship vehicle: IS and removed C++23 Targeted at C++23 labels Feb 18, 2020
@JeffGarland
Copy link
Member

This was reviewed in Saturday afternoon small group in Prague (notes on wiki). Feedback provided to the author with some revisions needed.

@JeffGarland JeffGarland added lwg-prereview Needs LWG initial review before full group needs-revision Paper needs changes before it can proceed labels Mar 25, 2020
@jensmaurer jensmaurer removed this from the 2020-telecon milestone Apr 24, 2020
@ben-craig ben-craig added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - small paper size estimate labels Oct 17, 2020
@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review and removed lwg-prereview Needs LWG initial review before full group needs-revision Paper needs changes before it can proceed labels Dec 11, 2020
@JeffGarland
Copy link
Member

LWG reviewed 2020-12-11

https://wiki.edg.com/bin/view/Wg21fall2020/P1223-2020-12-11

After some discussion author agreed to update paper and return to LEWG to include the end of range in the return type on the principle of not discarding potentially useful information.

We recommend LEWG change the return type to include the end of the range.
SF F N A SA
1 4 1 0 0
Participants: 6

@JeffGarland JeffGarland added the needs-revision Paper needs changes before it can proceed label Jan 12, 2021
@brycelelbach brycelelbach added SG9 Ranges SG expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. and removed expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. labels Feb 1, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Feb 22, 2022

P1223R3 find_last (Zach Laine)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Feb 22, 2022
@wg21bot wg21bot added this to the 2022-telecon milestone Feb 22, 2022
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Apr 1, 2022
@inbal2l inbal2l changed the title P1223 find_backward P1223 find_last Apr 11, 2022
@inbal2l inbal2l added expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Apr 12, 2022
@inbal2l
Copy link
Collaborator

inbal2l commented Apr 12, 2022

2022-04-11 SG9 (Ranges)

P1223R3: find_last

2022-04-11 SG9 (Ranges)

Chair: Inbal Levi

Champion: Jeff Garland

Minute Taker: Dietmar Kühl

Polls

Poll: We recommend making the change proposed in section 0.3 of P1223R3 for find_last, (making find_last returning a subrange) for C++23.

SF F N A SA
1 4 5 1 0

Outcome: Weak consensus in favor

Chair Note: There are a lot of Neutrals, but I think the 5 for vs. 1 against signals a weak consensus in favor. We should get LEWG's opinion anyhow

Summary

The paper was sent back from LWG to get SG9's input. The author supports the change on section 0.3 of R3, whether LWG and SG's opinions vary on this matter.

SG9's recommendation was to move forward with the change, (5F to 1A) but the vote had a large number of Neutrals. The topic will be reviewed in an LEWG ML.

Outcome

The topic of weather to move forward with the change is scheduled for LEWG ML review (starting on April 11th, 2022), with a weak recommendation by SG9 to accept the change proposed on R3 of the paper.

@inbal2l inbal2l added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed SG9 Ranges SG labels Apr 15, 2022
@inbal2l
Copy link
Collaborator

inbal2l commented Apr 15, 2022

LWG sent the paper back to LEWG (and SG9 first) to review a change in return types came up in LWG (suggested change appears in R3 section 0.3).
Discussed in an LEWG mailing list review: 2022-04-12
Review closed with a recommendation to move forward with the change (for C++23, to be approved with an electronic poll).

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Apr 22, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Apr 25, 2022

P1223R4 find_last (Zach Laine)

@brycelelbach
Copy link

2022-05 Library Evolution Electronic Poll Outcomes

POLL: Return [P1223R3] find_last to Library Working Group for C++23, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
13 9 1 1 0

Consensus in favor.

@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 19, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Jun 24, 2022

P1223R5 find_last (Zach Laine)

@JeffGarland
Copy link
Member

LWG reviewed and approved for C++23 on 2022-06-17

https://wiki.edg.com/bin/view/Wg21telecons2022/P1223-20220617

poll: put P1223r5 into C++23

F A N
7 0 0

(10 participants)

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-fullreview Paper is ready for lwg full group review B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - small paper size estimate labels Jul 4, 2022
@jensmaurer jensmaurer mentioned this issue Jul 24, 2022
Merged
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Milestone
2022-telecon
Development

Successfully merging a pull request may close this issue.

P1223R5 find_last cplusplus/draft
9 participants
@mclow @brycelelbach @ben-craig @cor3ntin @JeffGarland @inbal2l @tituswinters @jensmaurer @wg21bot