-
Notifications
You must be signed in to change notification settings - Fork 201
Include git hash in package lock comment for unversioned packages #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey Astiolo, thanks for the issue! I agree that it makes a lot of sense to track the current commit hash in the package lock. This would also be a step towards a more modern package management approach (#99) and allow automatic updates etc in the future. |
💯 should be doing this for the Also 'unversioned'... maybe should be non-versioned? |
I have just found Lines 756 to 762 in 63d0de7
|
I think the original reasoning was that |
Sometimes it's nice to have things building the latest version of something, while still being able to record the state it was in at the time.
I think this can be solved by including a git hash in the cpm-package-lock.cmake file in the build directory, so when archiving versions of the output, you can include that with it to know exactly what state the packages were in at the time it was built.
The text was updated successfully, but these errors were encountered: